Rust: Add another disjunct to postWithInFlowExclude - #19195
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- rust/ql/lib/codeql/rust/dataflow/internal/DataFlowConsistency.qll: Language not supported
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
geoffw0
reviewed
Apr 4, 2025
| or | ||
| n.(Node::PostUpdateNode).getPreUpdateNode().asExpr() = getPostUpdateReverseStep(_, _) | ||
| or | ||
| FlowSummaryImpl::Private::Steps::sourceLocalStep(_, n, _) |
Contributor
There was a problem hiding this comment.
What does this do? Why doesn't it affect any tests? Would any changes show up in a DCA run?
Contributor
Author
There was a problem hiding this comment.
It affects the tests in your PR. DCA will report fewer data flow inconsistencies, but it is hardly worth spending CPU cycles on that.
geoffw0
approved these changes
Apr 4, 2025
geoffw0
left a comment
geoffw0
left a comment
Contributor
There was a problem hiding this comment.
Confirmed - it works. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.