Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Update PreprocBlock.qll QLDoc and add C++23 test #18553

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Jan 21, 2025

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@jketema jketema added the no-change-note-required This PR does not need a change note label Jan 21, 2025
@jketema jketema requested review from geoffw0 and Copilot January 21, 2025 17:03
@jketema jketema requested a review from a team as a code owner January 21, 2025 17:03

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (4)
  • cpp/ql/lib/semmle/code/cpp/headers/PreprocBlock.qll: Language not supported
  • cpp/ql/test/library-tests/headers/preprocBlock/preprocblock.expected: Language not supported
  • cpp/ql/test/library-tests/headers/preprocBlock/preprocblock23.cpp: Language not supported
  • cpp/ql/test/library-tests/headers/preprocBlock/preprocinclude.expected: Language not supported

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@github-actions github-actions bot added the C++ label Jan 21, 2025
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating this.

@jketema
Copy link
Contributor Author

jketema commented Jan 22, 2025

LGTM, thanks for updating this.

You're welcome, and thanks for the review.

@jketema jketema merged commit 7fa9167 into github:main Jan 22, 2025
14 checks passed
@jketema jketema deleted the preprocblock branch January 22, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants