Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS: Fix FPs with js/incorrect-suffix-check #18547

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Jan 21, 2025

Fixes internal issue (see backref).

Evaluations were uneventful. I did a rerun of the nightly-old due to the first one hinting slightly towards a performance regression, but that disappeared on a rerun.

@github-actions github-actions bot added the JS label Jan 21, 2025
@erik-krogh erik-krogh marked this pull request as ready for review January 21, 2025 18:00
@erik-krogh erik-krogh requested a review from a team as a code owner January 21, 2025 18:00
Copy link
Collaborator

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Brief change note please, mentioning the validation pattern that is now recognised?

@erik-krogh erik-krogh merged commit 4bd4937 into github:main Jan 22, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants