Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: Improve bash support #18540

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Actions: Improve bash support #18540

merged 5 commits into from
Jan 28, 2025

Conversation

JarLob
Copy link
Contributor

@JarLob JarLob commented Jan 20, 2025

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@Copilot Copilot bot review requested due to automatic review settings January 20, 2025 15:20
@JarLob JarLob requested a review from a team as a code owner January 20, 2025 15:20
@github-actions github-actions bot added documentation Actions Analysis of GitHub Actions labels Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • actions/ql/lib/codeql/actions/Bash.qll: Language not supported
  • actions/ql/test/query-tests/Security/CWE-094/CodeInjectionCritical.expected: Language not supported
  • actions/ql/test/query-tests/Security/CWE-094/CodeInjectionMedium.expected: Language not supported
Comments suppressed due to low confidence (1)

actions/ql/test/query-tests/Security/CWE-094/.github/workflows/test19.yml:112

  • [nitpick] The step ID 'title2' is not descriptive. Consider renaming it to something more meaningful, such as 'fetch_pr_title'.
- id: title2

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@JarLob JarLob changed the title Improve bash support Actions: Improve bash support Jan 22, 2025
asgerf
asgerf previously approved these changes Jan 24, 2025
Copy link
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with an optional suggestion

actions/ql/lib/codeql/actions/Bash.qll Outdated Show resolved Hide resolved
@JarLob
Copy link
Contributor Author

JarLob commented Jan 27, 2025

I don't have merge permissions.

@asgerf asgerf merged commit 16634e6 into github:main Jan 28, 2025
11 checks passed
@JarLob JarLob deleted the bash branch January 28, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions Analysis of GitHub Actions documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants