-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++: Support #elifdef
, #elifndef
, and MSVC's #import
#18537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 16 changed files in this pull request and generated 1 comment.
Files not reviewed (10)
- cpp/downgrades/59cb96ca699929b63941e81905f9b8de7eed59a6/preprocdirects.ql: Language not supported
- cpp/downgrades/59cb96ca699929b63941e81905f9b8de7eed59a6/upgrade.properties: Language not supported
- cpp/ql/lib/semmle/code/cpp/Include.qll: Language not supported
- cpp/ql/lib/semmle/code/cpp/Preprocessor.qll: Language not supported
- cpp/ql/lib/semmlecode.cpp.dbscheme: Language not supported
- cpp/ql/lib/upgrades/1aa71a4a687fc93f807d4dfeeef70feceeced242/upgrade.properties: Language not supported
- cpp/ql/test/library-tests/preprocessor/preprocessor/pp23.cpp: Language not supported
- cpp/ql/test/library-tests/preprocessor/preprocessor/ppms.cpp: Language not supported
- cpp/ql/test/library-tests/preprocessor/preprocessor/preproc.expected: Language not supported
- cpp/ql/test/library-tests/preprocessor/preprocessor/test.tlh: Language not supported
Comments suppressed due to low confidence (1)
cpp/ql/lib/change-notes/2024-01-20-elifdef.md:5
- The phrase 'which represents the
#import
preprocessor directive as used by the Microsoft Visual C++ for importing type libraries' could be clearer. It should be 'which represents the#import
preprocessor directive used by Microsoft Visual C++ for importing type libraries.'
* A new class `TypeLibraryImport` was introduced, which represents the `#import` preprocessor directive as used by the Microsoft Visual C++ for importing type libraries.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The force push didn't change anything as far as I can tell (a merge
would have been easier to review).
Sorry, just dealing with a submodule bump in what is for me the least headache inducing way. |
Pull Request checklist
All query authors
.qhelp
. See the documentation in this repository.Internal query authors only
.ql
,.qll
, or.qhelp
files. See the documentation (internal access required).