Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Support #elifdef, #elifndef, and MSVC's #import #18537

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Jan 20, 2025

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@jketema jketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Jan 20, 2025
@jketema jketema marked this pull request as ready for review January 20, 2025 15:44
@Copilot Copilot bot review requested due to automatic review settings January 20, 2025 15:44
@jketema jketema requested a review from a team as a code owner January 20, 2025 15:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 16 changed files in this pull request and generated 1 comment.

Files not reviewed (10)
  • cpp/downgrades/59cb96ca699929b63941e81905f9b8de7eed59a6/preprocdirects.ql: Language not supported
  • cpp/downgrades/59cb96ca699929b63941e81905f9b8de7eed59a6/upgrade.properties: Language not supported
  • cpp/ql/lib/semmle/code/cpp/Include.qll: Language not supported
  • cpp/ql/lib/semmle/code/cpp/Preprocessor.qll: Language not supported
  • cpp/ql/lib/semmlecode.cpp.dbscheme: Language not supported
  • cpp/ql/lib/upgrades/1aa71a4a687fc93f807d4dfeeef70feceeced242/upgrade.properties: Language not supported
  • cpp/ql/test/library-tests/preprocessor/preprocessor/pp23.cpp: Language not supported
  • cpp/ql/test/library-tests/preprocessor/preprocessor/ppms.cpp: Language not supported
  • cpp/ql/test/library-tests/preprocessor/preprocessor/preproc.expected: Language not supported
  • cpp/ql/test/library-tests/preprocessor/preprocessor/test.tlh: Language not supported
Comments suppressed due to low confidence (1)

cpp/ql/lib/change-notes/2024-01-20-elifdef.md:5

  • The phrase 'which represents the #import preprocessor directive as used by the Microsoft Visual C++ for importing type libraries' could be clearer. It should be 'which represents the #import preprocessor directive used by Microsoft Visual C++ for importing type libraries.'
* A new class `TypeLibraryImport` was introduced, which represents the `#import` preprocessor directive as used by the Microsoft Visual C++ for importing type libraries.

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

cpp/ql/lib/change-notes/2024-01-20-elifdef.md Show resolved Hide resolved
esteffin
esteffin previously approved these changes Jan 20, 2025
Copy link

@esteffin esteffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

geoffw0
geoffw0 previously approved these changes Jan 20, 2025
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The force push didn't change anything as far as I can tell (a merge would have been easier to review).

@jketema
Copy link
Contributor Author

jketema commented Jan 21, 2025

The force push didn't change anything as far as I can tell (a merge would have been easier to review).

Sorry, just dealing with a submodule bump in what is for me the least headache inducing way.

@jketema jketema merged commit 91f6498 into github:main Jan 21, 2025
14 of 15 checks passed
@jketema jketema deleted the elifdef branch January 21, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants