Skip to content

JS: Fix semantic merge conflict: Implement new signature members in StepInputSig #18513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025
+12 −0
Merged

JS: Fix semantic merge conflict: Implement new signature members in StepInputSig #18513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions javascript/ql/lib/semmle/javascript/dataflow/internal/FlowSummaryPrivate.qll
View file
Original file line number Diff line number Diff line change
@@ -16,6 +16,14 @@ private import semmle.javascript.internal.flow_summaries.ExceptionFlow
*/
class SummarizedCallableBase = string;

class SourceBase extends Unit {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, you can use the Void type from codeql.util.Void.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do next time. In this case I'd rather unbreak main asap.

SourceBase() { none() }
}

class SinkBase extends Unit {
SinkBase() { none() }
}

/** Gets the parameter position representing a callback itself, if any. */
ArgumentPosition callbackSelfParameterPosition() { result.isFunctionSelfReference() }

@@ -139,6 +147,10 @@ private module FlowSummaryStepInput implements Private::StepsInputSig {
]
)
}

DataFlow::Node getSourceNode(SourceBase source, Private::SummaryComponent sc) { none() }

DataFlow::Node getSinkNode(SinkBase sink, Private::SummaryComponent sc) { none() }
}

module Steps = Private::Steps<FlowSummaryStepInput>;