C#: Fix crash if proxy environment variables are already set #18469
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
aibaars
approved these changes
Jan 10, 2025
|
CI is green and thanks for the approvals. I will run a manual test with a CodeQL bundle built using these changes in a workflow that uses the proxy to verify that works as well (I don't believe we have any automated tests for that at the moment). |
|
Test result looked fine, merging. |
mbg
deleted the
mbg/csharp/fix-crash-if-proxy-env-vars-are-already-set
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an extractor crash if any of the three environment variables are already set (existing values will be overridden). This problem was reported to us by a customer who already has
HTTP_PROXYandHTTPS_PROXYset on their runner. Overriding the existing values should be the desired behaviour here, because the Dependabot proxy settings are only available if there is a private registry configuration and the Dependabot proxy was started.I have also removed some incorrect log output in the first commit.