Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Delete jobs that moved to the internal repo. #17377

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

criemen
Copy link
Collaborator

@criemen criemen commented Sep 4, 2024

All jobs that are deleted have been moved to the internal repo.

The unit tests are also run internally through bazel, but keeping them here also tests the msbuild build.

All jobs that are deleted have been moved to the internal repo.

The unit tests are also run internally through bazel,
but keeping them here also tests the msbuild build.
@criemen criemen requested a review from a team September 4, 2024 10:40
@criemen criemen added the C# label Sep 4, 2024
@criemen criemen marked this pull request as ready for review September 4, 2024 10:40
@criemen criemen requested a review from a team as a code owner September 4, 2024 10:40
unit-tests:
strategy:
matrix:
os: [ubuntu-latest, windows-2019]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- name: Setup dotnet
- name: Setup dotnetg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh totally

oscarsj
oscarsj previously approved these changes Sep 4, 2024
Copy link
Contributor

@oscarsj oscarsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - check out a possible type before merging

@criemen criemen merged commit f9e956d into main Sep 4, 2024
9 checks passed
@criemen criemen deleted the criemen/csharp-move-jobs branch September 4, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants