Swift: Revert:Revert "Swift: CommonCrypto test cases for the BrokenCryptoAlgorithm query" #15106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gorithm query"" This reverts commit a478980.
MathiasVP
previously approved these changes
Dec 14, 2023
Contributor
MathiasVP
left a comment
MathiasVP
left a comment
There was a problem hiding this comment.
LGTM once CI is happy 🤞
Contributor
Author
|
Thanks, I'm going to try and narrow down which part CI is failing on and uncomment some of the code... |
Contributor
Author
|
This is ready now, and CI is happy. |
MathiasVP
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #15094, that is, put back the test that was introduced in #13870 . These tests encountered an extraction issue on Linux CI. The goal of this PR is to get the test cases back in, as I don't want to lose them, with any problematic parts disabled so that CI passes. There are issues tracking fixing the extraction problem itself and for repairing the affected tests afterwards (this isn't the only one).
It will take me a few iterations to get this passing CI. Please don't review / merge until then.