Address False Positives for Autosar #266

jeongsoolee09 · 2023-03-23T03:36:03Z

Description

Address FPs for AUTOSAR A5-2-6, A0-1-1, A2-7-3, and A15-4-4.

Change request type

Release or process automation (GitHub workflows, internal scripts)
Internal documentation
External documentation
Query files (.ql, .qll, .qls or unit tests)
External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

No rules added
Queries have been added for the following rules:
- rule number here
Queries have been modified for the following rules:
- A2-7-3 (A2-7-3: Exclude compiler generated functions created from lambdas #229)
- A15-4-4 (A15-4-4: Exclude compiler generated functions created from lambdas #228)

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

The structure or layout of the release artifacts.
The evaluation performance (memory, execution time) of an existing query.
The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

Yes
No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

Have all the relevant rule package description files been checked in?
Have you verified that the metadata properties of each new query is set appropriately?
Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
Are the alert messages properly formatted and consistent with the style guide?
Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Does the query have an appropriate level of in-query comments/documentation?
Have you considered/identified possible edge cases?
Does the query not reinvent features in the standard library?
Can the query be simplified further (not golfed!)

Reviewer

Have all the relevant rule package description files been checked in?
Have you verified that the metadata properties of each new query is set appropriately?
Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
Are the alert messages properly formatted and consistent with the style guide?
Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Does the query have an appropriate level of in-query comments/documentation?
Have you considered/identified possible edge cases?
Does the query not reinvent features in the standard library?
Can the query be simplified further (not golfed!)

Remove testing of lambdas completely by removing the `and not ...` part.

github-actions · 2023-03-23T03:36:19Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-23T03:37:43Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-23T03:37:44Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

github-actions · 2023-03-23T03:37:59Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-23T03:39:38Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

jsinglet · 2023-03-23T03:39:52Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_PASS            : True
SUITE                : AUTOSAR
TEST_DIFFERENCE      : 
QUERY                : MissingNoExcept
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
RULE                 : A15-4-4
PACKAGE              : Exceptions1

TEST_PASS            : True
SUITE                : AUTOSAR
TEST_DIFFERENCE      : 
QUERY                : UndocumentedUserDefinedType
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
RULE                 : A2-7-3
PACKAGE              : Comments

TEST_PASS            : True
SUITE                : AUTOSAR
TEST_DIFFERENCE      : 
QUERY                : OperandsOfALogicalAndOrNotParenthesized
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
RULE                 : A5-2-6
PACKAGE              : OrderOfEvaluation

TEST_PASS            : False
SUITE                : AUTOSAR
TEST_DIFFERENCE      : 
QUERY                : UselessAssignment
COMPILE_PASS         : False
COMPILE_ERROR_OUTPUT : [2023-03-23 03:39:52] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/autosar/test/rules/A0-1-1/test.cpp:34:9: error: redefinition of 'b5'
                       [2023-03-23 03:39:52] [build-stderr]   auto &b5 = new B();
                       [2023-03-23 03:39:52] [build-stderr]         ^
                       [2023-03-23 03:39:52] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/autosar/test/rules/A0-1-1/test.cpp:32:9: note: previous definition is here
                       [2023-03-23 03:39:52] [build-stderr]   auto &b5 = *new B();
                       [2023-03-23 03:39:52] [build-stderr]         ^
                       [2023-03-23 03:39:52] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/autosar/test/rules/A0-1-1/test.cpp:68:6: warning: expression result unused [-Wunused-value]
                       [2023-03-23 03:39:52] [build-stderr]   l2 + 5;
                       [2023-03-23 03:39:52] [build-stderr]   ~~ ^ ~
                       [2023-03-23 03:39:52] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/autosar/test/rules/A0-1-1/test.cpp:71:5: warning: expression result unused [-Wunused-value]
                       [2023-03-23 03:39:52] [build-stderr]   p + 5;
                       [2023-03-23 03:39:52] [build-stderr]   ~ ^ ~
                       [2023-03-23 03:39:52] [build-stderr] 2 warnings and 1 error generated.
                       [2023-03-23 03:39:52] [ERROR] Spawned process exited abnormally (code 1; tried to run: [/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql/tools/linux64/preload_tracer, clang++, -std=c++14, -fsyntax-only, /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/autosar/test/rules/A0-1-1/test.cpp])
                       
RULE                 : A0-1-1
PACKAGE              : DeadCode

jsinglet · 2023-03-23T03:40:26Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

jsinglet · 2023-03-23T03:40:27Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-23T03:40:34Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-23T03:41:17Z

🤖 Beep Boop! qcc/c/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

jsinglet · 2023-03-23T03:41:55Z

🤖 Beep Boop! qcc/c/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

jsinglet · 2023-03-23T03:42:29Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed. See below for the results!


COMPILE_PASS         : True
SUITE                : AUTOSAR
PACKAGE              : Exceptions1
TEST_DIFFERENCE      : 
TEST_PASS            : True
QUERY                : MissingNoExcept
RULE                 : A15-4-4
COMPILE_ERROR_OUTPUT : 

COMPILE_PASS         : True
SUITE                : AUTOSAR
PACKAGE              : Comments
TEST_DIFFERENCE      : 
TEST_PASS            : True
QUERY                : UndocumentedUserDefinedType
RULE                 : A2-7-3
COMPILE_ERROR_OUTPUT : 

COMPILE_PASS         : True
SUITE                : AUTOSAR
PACKAGE              : OrderOfEvaluation
TEST_DIFFERENCE      : 
TEST_PASS            : True
QUERY                : OperandsOfALogicalAndOrNotParenthesized
RULE                 : A5-2-6
COMPILE_ERROR_OUTPUT : 

COMPILE_PASS         : False
SUITE                : AUTOSAR
PACKAGE              : DeadCode
TEST_DIFFERENCE      : 
TEST_PASS            : False
QUERY                : UselessAssignment
RULE                 : A0-1-1
COMPILE_ERROR_OUTPUT : [2023-03-23 03:42:29] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/autosar/test/rules/A0-1-1/test.cpp: In function 'void foo(B&)':
                       [2023-03-23 03:42:29] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/autosar/test/rules/A0-1-1/test.cpp:34:9: error: conflicting declaration 'auto& b5'
                       [2023-03-23 03:42:29] [build-stderr]    auto &b5 = new B();
                       [2023-03-23 03:42:29] [build-stderr]          ^~
                       [2023-03-23 03:42:29] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/autosar/test/rules/A0-1-1/test.cpp:32:9: note: previous declaration as 'B& b5'
                       [2023-03-23 03:42:29] [build-stderr]    auto &b5 = *new B();
                       [2023-03-23 03:42:29] [build-stderr]          ^~
                       [2023-03-23 03:42:29] [ERROR] Spawned process exited abnormally (code 1; tried to run: [/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql/tools/linux64/preload_tracer, g++, -std=c++14, -fsyntax-only, /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/autosar/test/rules/A0-1-1/test.cpp])

jsinglet · 2023-03-23T03:42:30Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed. See below for the results!


PACKAGE              : Exceptions1
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
RULE                 : A15-4-4
TEST_PASS            : True
SUITE                : AUTOSAR
QUERY                : MissingNoExcept
TEST_DIFFERENCE      : 

PACKAGE              : Comments
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
RULE                 : A2-7-3
TEST_PASS            : True
SUITE                : AUTOSAR
QUERY                : UndocumentedUserDefinedType
TEST_DIFFERENCE      : 

PACKAGE              : OrderOfEvaluation
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
RULE                 : A5-2-6
TEST_PASS            : True
SUITE                : AUTOSAR
QUERY                : OperandsOfALogicalAndOrNotParenthesized
TEST_DIFFERENCE      : 

PACKAGE              : DeadCode
COMPILE_ERROR_OUTPUT : [2023-03-23 03:42:29] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/autosar/test/rules/A0-1-1/test.cpp: In function 'void foo(B&)':
                       [2023-03-23 03:42:29] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/autosar/test/rules/A0-1-1/test.cpp:34:9: error: conflicting declaration 'auto& b5'
                       [2023-03-23 03:42:29] [build-stderr]    auto &b5 = new B();
                       [2023-03-23 03:42:29] [build-stderr]          ^~
                       [2023-03-23 03:42:29] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/autosar/test/rules/A0-1-1/test.cpp:32:9: note: previous declaration as 'B& b5'
                       [2023-03-23 03:42:29] [build-stderr]    auto &b5 = *new B();
                       [2023-03-23 03:42:29] [build-stderr]          ^~
                       [2023-03-23 03:42:30] [ERROR] Spawned process exited abnormally (code 1; tried to run: [/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql/tools/linux64/preload_tracer, g++, -std=c++14, -fsyntax-only, /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/autosar/test/rules/A0-1-1/test.cpp])
                       
COMPILE_PASS         : False
RULE                 : A0-1-1
TEST_PASS            : False
SUITE                : AUTOSAR
QUERY                : UselessAssignment
TEST_DIFFERENCE      :

jsinglet · 2023-03-23T03:42:32Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_DIFFERENCE      : 
PACKAGE              : Exceptions1
COMPILE_ERROR_OUTPUT : 
TEST_PASS            : True
QUERY                : MissingNoExcept
COMPILE_PASS         : True
RULE                 : A15-4-4
SUITE                : AUTOSAR

TEST_DIFFERENCE      : 
PACKAGE              : Comments
COMPILE_ERROR_OUTPUT : 
TEST_PASS            : True
QUERY                : UndocumentedUserDefinedType
COMPILE_PASS         : True
RULE                 : A2-7-3
SUITE                : AUTOSAR

TEST_DIFFERENCE      : 
PACKAGE              : OrderOfEvaluation
COMPILE_ERROR_OUTPUT : 
TEST_PASS            : True
QUERY                : OperandsOfALogicalAndOrNotParenthesized
COMPILE_PASS         : True
RULE                 : A5-2-6
SUITE                : AUTOSAR

TEST_DIFFERENCE      : 
PACKAGE              : DeadCode
COMPILE_ERROR_OUTPUT : [2023-03-23 03:42:31] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/autosar/test/rules/A0-1-1/test.cpp:34:9: error: redefinition of 'b5'
                       [2023-03-23 03:42:31] [build-stderr]   auto &b5 = new B();
                       [2023-03-23 03:42:31] [build-stderr]         ^
                       [2023-03-23 03:42:31] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/autosar/test/rules/A0-1-1/test.cpp:32:9: note: previous definition is here
                       [2023-03-23 03:42:31] [build-stderr]   auto &b5 = *new B();
                       [2023-03-23 03:42:31] [build-stderr]         ^
                       [2023-03-23 03:42:31] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/autosar/test/rules/A0-1-1/test.cpp:68:6: warning: expression result unused [-Wunused-value]
                       [2023-03-23 03:42:31] [build-stderr]   l2 + 5;
                       [2023-03-23 03:42:31] [build-stderr]   ~~ ^ ~
                       [2023-03-23 03:42:31] [build-stderr] /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/autosar/test/rules/A0-1-1/test.cpp:71:5: warning: expression result unused [-Wunused-value]
                       [2023-03-23 03:42:31] [build-stderr]   p + 5;
                       [2023-03-23 03:42:31] [build-stderr]   ~ ^ ~
                       [2023-03-23 03:42:31] [build-stderr] 2 warnings and 1 error generated.
                       [2023-03-23 03:42:32] [ERROR] Spawned process exited abnormally (code 1; tried to run: [/__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql/tools/linux64/preload_tracer, clang++, -std=c++14, -fsyntax-only, /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/cpp/autosar/test/rules/A0-1-1/test.cpp])
                       
TEST_PASS            : False
QUERY                : UselessAssignment
COMPILE_PASS         : False
RULE                 : A0-1-1
SUITE                : AUTOSAR

jeongsoolee09 · 2023-04-26T16:16:10Z

/test-matrix

github-actions · 2023-04-26T16:16:34Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-04-26T16:17:49Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-04-26T16:17:52Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-04-26T16:21:48Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_DIFFERENCE      : 
TEST_PASS            : True
QUERY                : MissingNoExcept
COMPILE_PASS         : True
RULE                 : A15-4-4
SUITE                : AUTOSAR
PACKAGE              : Exceptions1
COMPILE_ERROR_OUTPUT : 

TEST_DIFFERENCE      : 
TEST_PASS            : True
QUERY                : UndocumentedUserDefinedType
COMPILE_PASS         : True
RULE                 : A2-7-3
SUITE                : AUTOSAR
PACKAGE              : Comments
COMPILE_ERROR_OUTPUT : 

TEST_DIFFERENCE      : 
TEST_PASS            : True
QUERY                : UselessAssignment
COMPILE_PASS         : True
RULE                 : A0-1-1
SUITE                : AUTOSAR
PACKAGE              : DeadCode
COMPILE_ERROR_OUTPUT : 

TEST_DIFFERENCE      : 
TEST_PASS            : True
QUERY                : OperandsOfALogicalAndOrNotParenthesized
COMPILE_PASS         : True
RULE                 : A5-2-6
SUITE                : AUTOSAR
PACKAGE              : OrderOfEvaluation
COMPILE_ERROR_OUTPUT :

jsinglet · 2023-04-26T16:21:49Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed. See below for the results!


PACKAGE              : Exceptions1
RULE                 : A15-4-4
COMPILE_PASS         : True
TEST_PASS            : True
SUITE                : AUTOSAR
QUERY                : MissingNoExcept
TEST_DIFFERENCE      : 
COMPILE_ERROR_OUTPUT : 

PACKAGE              : Comments
RULE                 : A2-7-3
COMPILE_PASS         : True
TEST_PASS            : True
SUITE                : AUTOSAR
QUERY                : UndocumentedUserDefinedType
TEST_DIFFERENCE      : 
COMPILE_ERROR_OUTPUT : 

PACKAGE              : DeadCode
RULE                 : A0-1-1
COMPILE_PASS         : True
TEST_PASS            : True
SUITE                : AUTOSAR
QUERY                : UselessAssignment
TEST_DIFFERENCE      : 
COMPILE_ERROR_OUTPUT : 

PACKAGE              : OrderOfEvaluation
RULE                 : A5-2-6
COMPILE_PASS         : True
TEST_PASS            : True
SUITE                : AUTOSAR
QUERY                : OperandsOfALogicalAndOrNotParenthesized
TEST_DIFFERENCE      : 
COMPILE_ERROR_OUTPUT :

jsinglet · 2023-04-26T16:21:51Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR has been completed. See below for the results!


COMPILE_ERROR_OUTPUT : 
PACKAGE              : Exceptions1
QUERY                : MissingNoExcept
COMPILE_PASS         : True
SUITE                : AUTOSAR
TEST_DIFFERENCE      : 
TEST_PASS            : True
RULE                 : A15-4-4

COMPILE_ERROR_OUTPUT : 
PACKAGE              : Comments
QUERY                : UndocumentedUserDefinedType
COMPILE_PASS         : True
SUITE                : AUTOSAR
TEST_DIFFERENCE      : 
TEST_PASS            : True
RULE                 : A2-7-3

COMPILE_ERROR_OUTPUT : 
PACKAGE              : DeadCode
QUERY                : UselessAssignment
COMPILE_PASS         : True
SUITE                : AUTOSAR
TEST_DIFFERENCE      : 
TEST_PASS            : True
RULE                 : A0-1-1

COMPILE_ERROR_OUTPUT : 
PACKAGE              : OrderOfEvaluation
QUERY                : OperandsOfALogicalAndOrNotParenthesized
COMPILE_PASS         : True
SUITE                : AUTOSAR
TEST_DIFFERENCE      : 
TEST_PASS            : True
RULE                 : A5-2-6

jsinglet · 2023-04-26T16:23:05Z

🤖 Beep Boop! qcc/c/AARCH64LE Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-04-26T16:23:33Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

change_notes/2023-03-15-fix-reported-fp-for-A0-1-1.md

- A0-1-1: Couldn't repro, query file not touched at all - A5-2-6: Couldn't repro, file reverted to original

…odeql-coding-standards into jeongsoolee09/False-positives-1

jeongsoolee09 · 2023-04-26T19:28:20Z

/test-matrix

github-actions · 2023-04-26T19:28:36Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-04-26T19:29:43Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-04-26T19:31:33Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-04-26T19:31:47Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_PASS            : True
RULE                 : A15-4-4
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Exceptions1
TEST_DIFFERENCE      : 
COMPILE_PASS         : True
QUERY                : MissingNoExcept
SUITE                : AUTOSAR

TEST_PASS            : True
RULE                 : A2-7-3
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Comments
TEST_DIFFERENCE      : 
COMPILE_PASS         : True
QUERY                : UndocumentedUserDefinedType
SUITE                : AUTOSAR

TEST_PASS            : True
RULE                 : A0-1-1
COMPILE_ERROR_OUTPUT : 
PACKAGE              : DeadCode
TEST_DIFFERENCE      : 
COMPILE_PASS         : True
QUERY                : UselessAssignment
SUITE                : AUTOSAR

TEST_PASS            : True
RULE                 : A5-2-6
COMPILE_ERROR_OUTPUT : 
PACKAGE              : OrderOfEvaluation
TEST_DIFFERENCE      : 
COMPILE_PASS         : True
QUERY                : OperandsOfALogicalAndOrNotParenthesized
SUITE                : AUTOSAR

jsinglet · 2023-04-26T19:33:35Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed. See below for the results!


COMPILE_PASS         : True
RULE                 : A15-4-4
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
TEST_PASS            : True
PACKAGE              : Exceptions1
QUERY                : MissingNoExcept
SUITE                : AUTOSAR

COMPILE_PASS         : True
RULE                 : A2-7-3
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
TEST_PASS            : True
PACKAGE              : Comments
QUERY                : UndocumentedUserDefinedType
SUITE                : AUTOSAR

COMPILE_PASS         : True
RULE                 : A0-1-1
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
TEST_PASS            : True
PACKAGE              : DeadCode
QUERY                : UselessAssignment
SUITE                : AUTOSAR

COMPILE_PASS         : True
RULE                 : A5-2-6
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
TEST_PASS            : True
PACKAGE              : OrderOfEvaluation
QUERY                : OperandsOfALogicalAndOrNotParenthesized
SUITE                : AUTOSAR

jsinglet · 2023-04-26T19:33:42Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR has been completed. See below for the results!


TEST_DIFFERENCE      : 
SUITE                : AUTOSAR
TEST_PASS            : True
PACKAGE              : Exceptions1
QUERY                : MissingNoExcept
RULE                 : A15-4-4
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 

TEST_DIFFERENCE      : 
SUITE                : AUTOSAR
TEST_PASS            : True
PACKAGE              : Comments
QUERY                : UndocumentedUserDefinedType
RULE                 : A2-7-3
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 

TEST_DIFFERENCE      : 
SUITE                : AUTOSAR
TEST_PASS            : True
PACKAGE              : DeadCode
QUERY                : UselessAssignment
RULE                 : A0-1-1
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 

TEST_DIFFERENCE      : 
SUITE                : AUTOSAR
TEST_PASS            : True
PACKAGE              : OrderOfEvaluation
QUERY                : OperandsOfALogicalAndOrNotParenthesized
RULE                 : A5-2-6
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT :

jsinglet · 2023-04-26T19:34:51Z

🤖 Beep Boop! qcc/c/AARCH64LE Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-04-26T19:35:09Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

lcartey

Good job!

jeongsoolee09 added 12 commits March 14, 2023 13:52

Augment test.cpp

1cc399b

Reinforce A5-2-6

338c99c

Remove stuffs added temporarily

5fcb20a

Augment A15-4-4

c1dac08

Augment A2-7-3

d4adaa5

Remove testing of lambdas completely by removing the `and not ...` part.

Minor comment

58f134f

Add change notes for this batch

9dc1879

Add more cases for FP

5c3ccd1

Add supposed FP case

423328b

Add FP suspect case

55962dc

Another FP suspect case

845ba29

Add more FP suspect case

b9f0750

jeongsoolee09 marked this pull request as draft March 23, 2023 03:36

jeongsoolee09 requested a review from rvermeulen March 23, 2023 03:36

jeongsoolee09 requested a review from lcartey March 23, 2023 03:36

Merge branch 'main' into jeongsoolee09/False-positives-1

0c41e37

Merge branch 'main' into jeongsoolee09/False-positives-1

e2b9b4e

lcartey marked this pull request as ready for review April 26, 2023 16:33

lcartey requested changes Apr 26, 2023

View reviewed changes

change_notes/2023-03-15-fix-reported-fp-for-A0-1-1.md Outdated Show resolved Hide resolved

jeongsoolee09 added 2 commits April 26, 2023 12:12

Remove change notes for A0-1-1 and A5-2-6

ec79c88

- A0-1-1: Couldn't repro, query file not touched at all - A5-2-6: Couldn't repro, file reverted to original

Merge branch 'jeongsoolee09/False-positives-1' of github.com:github/c…

62c9825

…odeql-coding-standards into jeongsoolee09/False-positives-1

lcartey approved these changes Apr 26, 2023

View reviewed changes

lcartey added this pull request to the merge queue Apr 28, 2023

Merged via the queue into main with commit 35ef53b Apr 28, 2023

lcartey deleted the jeongsoolee09/False-positives-1 branch April 28, 2023 08:59

This was referenced May 5, 2023

A2-7-3: Exclude compiler generated functions created from lambdas #229

Closed

A15-4-4: Exclude compiler generated functions created from lambdas #228

Closed

Address False Positives for Autosar #266

Address False Positives for Autosar #266

Uh oh!

Conversation

jeongsoolee09 commented Mar 23, 2023 • edited by lcartey Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Change request type

Rules with added or modified queries

Release change checklist

Query development review checklist

Author

Reviewer

Uh oh!

github-actions bot commented Mar 23, 2023

Uh oh!

jsinglet commented Mar 23, 2023

Uh oh!

jsinglet commented Mar 23, 2023

Uh oh!

github-actions bot commented Mar 23, 2023

Uh oh!

jsinglet commented Mar 23, 2023

Uh oh!

jsinglet commented Mar 23, 2023

Uh oh!

jsinglet commented Mar 23, 2023

Uh oh!

jsinglet commented Mar 23, 2023

Uh oh!

jsinglet commented Mar 23, 2023

Uh oh!

jsinglet commented Mar 23, 2023

Uh oh!

jsinglet commented Mar 23, 2023

Uh oh!

jsinglet commented Mar 23, 2023

Uh oh!

jsinglet commented Mar 23, 2023

Uh oh!

jsinglet commented Mar 23, 2023

Uh oh!

jeongsoolee09 commented Apr 26, 2023

Uh oh!

github-actions bot commented Apr 26, 2023

Uh oh!

jsinglet commented Apr 26, 2023

Uh oh!

jsinglet commented Apr 26, 2023

Uh oh!

jsinglet commented Apr 26, 2023

Uh oh!

jsinglet commented Apr 26, 2023

Uh oh!

jsinglet commented Apr 26, 2023

Uh oh!

jsinglet commented Apr 26, 2023

Uh oh!

jsinglet commented Apr 26, 2023

Uh oh!

Uh oh!

jeongsoolee09 commented Apr 26, 2023

Uh oh!

github-actions bot commented Apr 26, 2023

Uh oh!

jsinglet commented Apr 26, 2023

Uh oh!

jsinglet commented Apr 26, 2023

Uh oh!

jsinglet commented Apr 26, 2023

Uh oh!

jsinglet commented Apr 26, 2023

Uh oh!

jsinglet commented Apr 26, 2023

Uh oh!

jsinglet commented Apr 26, 2023

Uh oh!

jsinglet commented Apr 26, 2023

Uh oh!

lcartey left a comment

jeongsoolee09 commented Mar 23, 2023 •

edited by lcartey

Loading