Skip to content

Comments

Update eslint to v9#3497

Open
henrymercer wants to merge 2 commits intomainfrom
henrymercer/eslint-v9
Open

Update eslint to v9#3497
henrymercer wants to merge 2 commits intomainfrom
henrymercer/eslint-v9

Conversation

@henrymercer
Copy link
Contributor

This PR updates eslint to v9. It is too early to update to v10 since some of our linter plugins don't yet have support.

The eslint config file has changed substantially due to converting to flat config and changes to upstream plugins. I have attempted to ensure that the rules we are running are the same, and note that there is only one change to disable directives, which is to remove a while (true) statement that is no longer flagged by the no constant condition linting rule. However this PR would benefit from a careful look at this config file.

I checked import/no-cycle manually, since this has caught user-visible issues for us in the past. Strangely I could not get import/no-cycle to work with eslint v9. It ran, but did not detect an example import cycle. I have replaced it by import-x/no-cycle, but it's still odd to me that this didn't work initially.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

Going through linter plugins to check rules, confirming other disable directives are still required.

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

n/a

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Copilot AI review requested due to automatic review settings February 20, 2026 16:36
@henrymercer henrymercer requested a review from a team as a code owner February 20, 2026 16:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades ESLint from v8 to v9, migrating to the new flat config format and updating related linting plugins. This is a development tooling change that does not affect runtime behavior of CodeQL Action workflows.

Changes:

  • Updated ESLint from v8.57.1 to v9.39.2 and migrated to flat config (eslint.config.mjs)
  • Replaced eslint-plugin-import with eslint-plugin-import-x and removed deprecated plugins
  • Removed an eslint-disable directive for no-constant-condition that is no longer needed in ESLint v9

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Updated ESLint and linting plugin versions
package-lock.json Auto-generated lockfile reflecting dependency updates
eslint.config.mjs Migrated from legacy to flat config format
src/upload-lib.ts Removed eslint-disable for no-constant-condition (rule now handles while(true) correctly)
lib/*.js Generated JavaScript files reflecting TypeScript source changes

@github-actions github-actions bot added the size/S Should be easy to review label Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Should be easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant