fix: Changed 'bash' to 'command' in hooks.json#1019
Draft
parveen-dotnet wants to merge 1 commit intogithub:stagedfrom
Draft
fix: Changed 'bash' to 'command' in hooks.json#1019parveen-dotnet wants to merge 1 commit intogithub:stagedfrom
parveen-dotnet wants to merge 1 commit intogithub:stagedfrom
Conversation
As per VS code docs, I don't find "bash" as a property in hooks, the best/suitable property is "command". Reference: https://code.visualstudio.com/docs/copilot/customization/hooks#_hook-command-properties
Contributor
|
This is, unfortunately, a case where we have deviation between implementations, as Copilot CLI uses a slightly different schema to what VS Code uses. Before we can action on this PR I'm going to have to work with the teams to get it aligned. |
Author
|
Thanks @aaronpowell for the clarification. I wasn't aware of the schema deviation between the Copilot CLI and VS Code implementations. I'll hold off on this change for now until the schemas are aligned. Please let me know once there's an update and I’ll be happy to revisit the PR. |
Contributor
|
We're actively tracking the changes internally on CLI so hopefully it won't be too long |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per VS code docs, I don't find "bash" as a property in hooks, the best/suitable property is "command". Reference:
https://code.visualstudio.com/docs/copilot/customization/hooks#_hook-command-properties
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.Description
Changed 'bash' to 'command' in hooks.json
As per VS code docs, I don't find "bash" as a property in hooks, the best/suitable property is "command". Reference:
https://code.visualstudio.com/docs/copilot/customization/hooks#_hook-command-properties
Type of Contribution
Additional Notes
By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.