Conversation
…native implementation
There was a problem hiding this comment.
Pull Request Overview
This PR adds Firefox browser testing support to the web-test-runner configuration by integrating the @web/test-runner-playwright package. The changes enable testing of the ariaNotify polyfill in Firefox, which is important since Firefox doesn't have native support for the ariaNotify API, making it an ideal target for polyfill testing.
- Adds
@web/test-runner-playwrightdependency to enable Playwright browser launcher integration - Configures web-test-runner to use Firefox instead of the default Chrome browser
- Removes
--legacy-peer-depsflag from CI workflows, suggesting resolved dependency conflicts
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| web-test-runner.config.js | Imports and configures Playwright launcher to run tests in Firefox with headless mode enabled and CI-specific executable path |
| package.json | Adds @web/test-runner-playwright ^0.11.1 as a dev dependency |
| package-lock.json | Locks @web/test-runner-playwright at version 0.11.1 with its transitive dependencies including playwright ^1.53.0 |
| .github/workflows/test.yml | Removes --legacy-peer-deps flag from npm ci command |
| .github/workflows/publish.yml | Removes --legacy-peer-deps flag from npm ci command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… “Juggler” remote debugging protocol, so we have to install Playwright’s version (which includes “Juggler”) after all
lindseywild
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.