Update for new pythonjsonlogger #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- requirements/requirements-dev.txt: Language not supported
Comments suppressed due to low confidence (3)
example/logging_config.py:96
- Ensure that there are tests verifying the new path for the JsonFormatter class to prevent regressions.
"class": "pythonjsonlogger.json.JsonFormatter",
example/logging_config.py:119
- Ensure that there are tests verifying the new path for the JsonFormatter class to prevent regressions.
"class": "pythonjsonlogger.json.JsonFormatter",
annotated_logger/init.py:112
- Ensure that the new path for JsonFormatter is covered by tests to verify that the logging configuration works correctly with the updated class path.
"class": "pythonjsonlogger.json.JsonFormatter", # pragma: no mutate
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
crimsonknave
temporarily deployed
to
testpypi
GitHub Actions
Inactive
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
sophiagavrila
previously approved these changes
Dec 13, 2024
crimsonknave
temporarily deployed
to
testpypi
GitHub Actions
Inactive
sophiagavrila
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python-json-loggerhas a new major version update and moved one of it's classes that was used. This sets the requirement to the version that changed the path and updates to use the new path.