This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Create and add MEF commands on background thread#1548
Closed
jcansdale wants to merge 5 commits into
Closed
Conversation
There is no need to do this on the Main thread.
Call the IShowCurrentPullRequestCommand directly rather than using DTE.
jcansdale
commented
Mar 21, 2018
|
|
||
| namespace GitHub.Services.Vssdk | ||
| { | ||
| public abstract class AsyncMenuPackage : AsyncPackage |
Collaborator
Author
There was a problem hiding this comment.
Needs some (preferably gramatical) xmldoc comments. 😉
Collaborator
Author
|
Made obsolete by #1569. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
AsyncMenuPackagethat allowsIMenuCommandServiceto be used on b/g treadPullRequestStatusBarPackageuse MEF on b/g thread before using it on Main threadNotes
I attempted to do everything on the background thread, including calling
AddCommandon theIMenuCommandServiceservice. There had been reports of this also working on a background thread:https://gitter.im/Microsoft/extendvs?at=5ab13986458cbde55757fe4e
Unfortunately
MenuCommandService.EnsureVerbsincludes a call toGetService:https://gitter.im/Microsoft/extendvs?at=5ab141aaf3f6d24c6898259e
This can only be called on a background thread by a non-
AsyncPackage, for exampe:http://source.roslyn.io/#Microsoft.VisualStudio.LanguageServices/RoslynPackage.cs,106
(
IMenuCommandServiceandIOleCommandTarget) are services that are created for eachPackage)IMenuCommandService.AddCommands to be called form a background thread:
This allows us to do all menu related initialization on a b/g thread!