Skip to content

fix: retry all SQS messages on unhandled errors instead of silently dropping them #5109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Snojo wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −4
Open

fix: retry all SQS messages on unhandled errors instead of silently dropping them #5109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40feda1
fix: retry all SQS messages on unhandled errors instead of silently d…
Snojo Apr 16, 2026
46347b8
test: update test to expect all messages retried on unhandled error
Snojo Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lambdas/functions/control-plane/src/lambda.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,9 @@ describe('Test scale up lambda wrapper.', () => {
vi.mocked(scaleUp).mockRejectedValue(new Error('Generic error'));

const result = await scaleUpHandler(multiRecordEvent, context);
expect(result).toEqual({ batchItemFailures: [] });
expect(result).toEqual({
batchItemFailures: [{ itemIdentifier: 'message-0' }, { itemIdentifier: 'message-1' }],
});
});

it('Should throw when scaleUp throws ScaleError', async () => {
Expand Down
8 changes: 5 additions & 3 deletions lambdas/functions/control-plane/src/lambda.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,11 @@ export async function scaleUpHandler(event: SQSEvent, context: Context): Promise
batchItemFailures.push(...e.toBatchItemFailures(sqsMessages));
logger.warn(`${e.detailedMessage} A retry will be attempted via SQS.`, { error: e });
} else {
logger.error(`Error processing batch (size: ${sqsMessages.length}): ${(e as Error).message}, ignoring batch`, {
error: e,
});
batchItemFailures.push(...sqsMessages.map(({ messageId }) => ({ itemIdentifier: messageId })));
logger.error(
`Error processing batch (size: ${sqsMessages.length}): ${(e as Error).message}, all messages will be retried via SQS.`,
{ error: e },
);
}

return { batchItemFailures };
Expand Down