Skip to content

feat: Add feature to enable dynamic instance types via workflow labels #4529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

npalm
Copy link
Member

@npalm npalm commented Apr 8, 2025

Description

This PR adds an option to define the required instance type via the workflow labels. This could be all tricky, since in the end GH decides which workflo runs on a runner.

By adding a label to the workflow starting with ghr-ec2- and followed by the instance type a runenr for the required instance type is caled (only if the teature is enabled).

For example: ghr-ec2-m5.xlarge
image

Limitiation

  • No support for pool (since not scaled by eventts)

Status

Early draft, just a POC, no tests, no docs, requires rerfactoing.

Todo

  • Decide if this should enter the main line? If yes
  • Refactor feature config to an object, containing enable and prefix
  • Add docs including limitations
  • Add unit tests
  • Adjust an example, enable feature. Ephemeral case with job retry.
  • Adjust logging

@npalm npalm requested review from a team as code owners April 8, 2025 13:03
@npalm npalm marked this pull request as draft April 8, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant