fix(stats): the collector's rate, its windows, and what happens when a VNI changes hands - #1765
Merged
daniel-noland merged 0 commit intoAug 28, 2026
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
daniel-noland
force-pushed
the
pr/daniel-noland/stats-collector
branch
from
August 26, 2026 17:30
d6aafee to
8e8c974
Compare
daniel-noland
force-pushed
the
pr/daniel-noland/stats-collector
branch
from
August 26, 2026 19:36
8e8c974 to
b5b7d84
Compare
daniel-noland
force-pushed
the
pr/daniel-noland/stats-collector
branch
from
August 26, 2026 20:41
b5b7d84 to
2b5e4b8
Compare
daniel-noland
force-pushed
the
pr/daniel-noland/stats-collector
branch
from
August 26, 2026 21:02
2b5e4b8 to
4f24f0f
Compare
daniel-noland
force-pushed
the
pr/daniel-noland/stats-collector
branch
2 times, most recently
from
August 26, 2026 21:25
053a0fa to
d7e8fae
Compare
daniel-noland
force-pushed
the
pr/daniel-noland/stats-collector
branch
from
August 27, 2026 01:29
d7e8fae to
164ff53
Compare
daniel-noland
force-pushed
the
pr/daniel-noland/stats-collector
branch
from
August 27, 2026 01:41
164ff53 to
4585af0
Compare
daniel-noland
force-pushed
the
pr/daniel-noland/stats-collector
branch
from
August 27, 2026 02:26
4585af0 to
921fd16
Compare
daniel-noland
force-pushed
the
pr/daniel-noland/stats-collector
branch
from
August 27, 2026 04:41
921fd16 to
a204aab
Compare
daniel-noland
force-pushed
the
pr/daniel-noland/stats-collector
branch
2 times, most recently
from
August 27, 2026 06:30
a5e54c6 to
e127e47
Compare
daniel-noland
force-pushed
the
pr/daniel-noland/stats-collector
branch
from
August 27, 2026 18:00
e127e47 to
0b5dac2
Compare
daniel-noland
force-pushed
the
pr/daniel-noland/stats-collector
branch
2 times, most recently
from
August 28, 2026 02:38
a0daf04 to
347e534
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A steady load cannot test a rate pipeline, so the collector is driven with a ramp and its published rate asserted against the load that produced it. That found the rate window being read out of arrival order, startup batches that were not consecutive, a rate that could be negative or NaN, and a metric series that outlived its own name.
When a VNI changes hands its counters must reset and the traffic still in flight must be dropped; neither happened. Ends with a set of flow-entry and net fixes turned up by the same fuzzing.
24 commits. Stacked on
pr/daniel-noland/driven-clock; review that first.🤖 Generated with Claude Code