Add artifact conversion for fetch observations - #59
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a conversion method on fetch.FetchObservation to produce a shared artifacts.Artifact from a completed fetch observation, using the observed SHA-256 digest, byte count, media type, and caller-provided package URL + filename.
Changes:
- Added
(*FetchObservation).Artifact(packageURL, filename)to convert completed observations intoartifacts.Artifactvalues. - Added unit tests covering successful conversion and error cases (incomplete, nil, missing digest, malformed digest).
- Updated Go module dependencies to include
github.com/git-pkgs/artifactsandgithub.com/opencontainers/go-digest, and bumped related git-pkgs modules.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| go.mod | Adds artifacts + go-digest dependencies and bumps purl/vers versions. |
| go.sum | Updates checksums for the new/updated dependencies. |
| fetch/observation.go | Introduces FetchObservation.Artifact conversion method. |
| fetch/observation_test.go | Adds test coverage for Artifact conversion and its error handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
andrew
force-pushed
the
artifacts-adoption
branch
from
August 24, 2026 08:55
ed26ea5 to
96f031b
Compare
andrew
marked this pull request as ready for review
August 24, 2026 08:57
andrew
force-pushed
the
artifacts-adoption
branch
from
August 27, 2026 13:48
7ba2c27 to
306a9b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
FetchObservation.Artifactfor converting completed fetch observations intoartifacts.Artifactvalues. The conversion uses the observed SHA-256 digest, byte count, media type, and caller-supplied package URL and filename. It rejects incomplete observations and missing or malformed SHA-256 values.