Skip to content

Reduce trace2 event nesting#1738

Merged
svarlamov merged 1 commit into
mainfrom
fix/reduce-trace2-nesting
Jul 7, 2026
Merged

Reduce trace2 event nesting#1738
svarlamov merged 1 commit into
mainfrom
fix/reduce-trace2-nesting

Conversation

@svarlamov

@svarlamov svarlamov commented Jul 6, 2026

Copy link
Copy Markdown
Member

Summary

  • lower the installed and diagnosed trace2.eventNesting value from 10 to 0
  • update trace2-backed test harness defaults and direct raw Git trace invocations to exercise nesting 0 by default
  • keep the override hook GIT_AI_TEST_TRACE2_NESTING available for targeted comparisons
  • restack this on Fix Windows CI flakes #1739, which fixes the Windows CI failure already present on main

Validation

  • GIT_AI_TEST_TRACE2_NESTING=0 task test CARGO_TEST_ARGS='--test commit_tree_update_ref'
  • GIT_AI_TEST_TRACE2_NESTING=0 task test
  • task fmt
  • task test CARGO_TEST_ARGS='--test commit_tree_update_ref'
  • task test CARGO_TEST_ARGS='--test async_mode'
  • task test TEST_FILTER=graphite
  • task test CARGO_TEST_ARGS="--test notes_sync_regression"
  • task test CARGO_TEST_ARGS="--test integration" TEST_FILTER=tls_native_certs::test_https_request_uses_system_certs
  • task lint
  • git diff --check
  • task test with local /home/ubuntu/.opencode/bin removed from PATH because this workstation has an unrelated opencode binary that makes mdm::agents::opencode::tests::test_opencode_no_binary_no_config_not_detected fail on main too

Open in Devin Review

svarlamov commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@svarlamov svarlamov changed the title reduce trace2 event nesting Reduce trace2 event nesting Jul 6, 2026
@svarlamov
svarlamov marked this pull request as ready for review July 6, 2026 19:48

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@svarlamov
svarlamov changed the base branch from main to graphite-base/1738 July 6, 2026 20:31
@svarlamov
svarlamov force-pushed the fix/reduce-trace2-nesting branch from 515a916 to 5ecf3f2 Compare July 6, 2026 20:31
@svarlamov
svarlamov changed the base branch from graphite-base/1738 to fix/windows-ci-flakes July 6, 2026 20:31
@svarlamov svarlamov mentioned this pull request Jul 6, 2026
@svarlamov
svarlamov force-pushed the fix/reduce-trace2-nesting branch from 5ecf3f2 to 5c14e82 Compare July 6, 2026 21:31
devin-ai-integration[bot]

This comment was marked as resolved.

@svarlamov
svarlamov force-pushed the fix/reduce-trace2-nesting branch from 5c14e82 to bc97634 Compare July 6, 2026 23:39
devin-ai-integration[bot]

This comment was marked as resolved.

@Siddhant-K-code

Copy link
Copy Markdown
Collaborator

@svarlamov - I am unsure if it is intentional to have duplicate work from #1735 ?

@svarlamov
svarlamov force-pushed the fix/reduce-trace2-nesting branch from bc97634 to 0580b79 Compare July 7, 2026 13:58
@svarlamov
svarlamov changed the base branch from fix/windows-ci-flakes to graphite-base/1738 July 7, 2026 14:01
@svarlamov
svarlamov force-pushed the fix/reduce-trace2-nesting branch from 0580b79 to 9f913bb Compare July 7, 2026 14:01
@graphite-app
graphite-app Bot changed the base branch from graphite-base/1738 to main July 7, 2026 14:01
@svarlamov
svarlamov force-pushed the fix/reduce-trace2-nesting branch from 9f913bb to bb03251 Compare July 7, 2026 14:01
@svarlamov
svarlamov merged commit ff65c9a into main Jul 7, 2026
31 of 33 checks passed
@svarlamov
svarlamov deleted the fix/reduce-trace2-nesting branch July 7, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants