[codex] Optimize trace2 ingestion side effects#1651
Open
svarlamov wants to merge 1 commit into
Open
Conversation
4488ce8 to
d7d3ce0
Compare
198023f to
060f578
Compare
060f578 to
cd170ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Trace2 ingestion still did too much synchronous work: broad reflog scans, inline command side effects, and broad family blocking on trace roots that had not identified a repo. Under suite load, an incomplete root could leave later checkpoints waiting behind unrelated trace state.
Validation
task buildtask linttask fmttask test CARGO_TEST_ARGS="--lib"task test CARGO_TEST_ARGS="--test daemon_mode"task test CARGO_TEST_ARGS="--test integration"Focused regression checks also passed for cold conflict rebase, pull-rebase/autostash, Cursor attribution, partial staging, subdir amend, and large stash note cases.