Fix Copilot VS Code selected model extraction#1638
Open
Siddhant-K-code wants to merge 3 commits into
Open
Conversation
51c71a8 to
3f1b268
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-traces.dbmodel lookup bychat_session_idmodels.jsondefault fallbackFixes #1559.
Validation
Run from the repo root on this branch:
task fmt task lint task test TEST_FILTER=test_copilot_preset_vscode_model_falls_back_to_selected_model_idExpected outcomes:
task fmtexits cleanly with no rustfmt diffs.task lintexits cleanly with no clippy/lint failures.unknown.Broader regression sweep:
task test TEST_FILTER=github_copilotExpected outcome: GitHub Copilot preset tests pass, including native VS Code hook parsing and selected-model fallback behavior.
Additional whitespace check:
Expected outcome: no output and exit code
0.Docs
No docs change needed. The fix changes internal model extraction for existing VS Code Copilot sessions and is covered by targeted tests.
Notes
PR for focused review and CI validation.