Skip to content

Fix Copilot VS Code selected model extraction#1638

Open
Siddhant-K-code wants to merge 3 commits into
git-ai-project:mainfrom
Siddhant-K-code:siddhant/1559-copilot-vscode-selected-model
Open

Fix Copilot VS Code selected model extraction#1638
Siddhant-K-code wants to merge 3 commits into
git-ai-project:mainfrom
Siddhant-K-code:siddhant/1559-copilot-vscode-selected-model

Conversation

@Siddhant-K-code

@Siddhant-K-code Siddhant-K-code commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add Copilot OTEL agent-traces.db model lookup by chat_session_id
  • Resolve VS Code Copilot models in order: transcript/event model, OTEL request model, OTEL response model, then models.json default fallback
  • Add temp SQLite regression coverage for selected model precedence

Fixes #1559.

Validation

Run from the repo root on this branch:

task fmt
task lint
task test TEST_FILTER=test_copilot_preset_vscode_model_falls_back_to_selected_model_id

Expected outcomes:

  • task fmt exits cleanly with no rustfmt diffs.
  • task lint exits cleanly with no clippy/lint failures.
  • The targeted Copilot model lookup test passes.
  • The regression fixture resolves the selected VS Code Copilot model from the OTEL/models lookup path instead of falling back to unknown.

Broader regression sweep:

task test TEST_FILTER=github_copilot

Expected outcome: GitHub Copilot preset tests pass, including native VS Code hook parsing and selected-model fallback behavior.

Additional whitespace check:

git diff --check origin/main..siddhant/1559-copilot-vscode-selected-model

Expected outcome: no output and exit code 0.

Docs

No docs change needed. The fix changes internal model extraction for existing VS Code Copilot sessions and is covered by targeted tests.

Notes

PR for focused review and CI validation.

@Siddhant-K-code Siddhant-K-code force-pushed the siddhant/1559-copilot-vscode-selected-model branch from 51c71a8 to 3f1b268 Compare June 24, 2026 11:20
@Siddhant-K-code Siddhant-K-code marked this pull request as ready for review June 24, 2026 11:23

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: VS Code Copilot always reports the account default model instead of the user-selected model

1 participant