Fix Cursor hook stdin decoding for CJK content#1637
Open
Siddhant-K-code wants to merge 1 commit into
Open
Conversation
d024b45 to
652bf54
Compare
652bf54 to
e25818e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--hook-input stdinas bytes before decodingFixes #1317.
Validation
Run from the repo root on this branch:
task fmt task lint task test TEST_FILTER=test_cursor_checkpoint_stdin_with_utf16le_odd_cjk_contentExpected outcomes:
task fmtexits cleanly with no rustfmt diffs.task lintexits cleanly with no clippy/lint failures.--hook-input stdin, the checkpoint command does not emitInvalid JSON in hook_input, and the committed CJK line is verified as AI-authored.Broader regression sweep:
task test TEST_FILTER=cursorExpected outcome: Cursor preset and integration tests pass, including UTF-8 BOM and UTF-16 stdin decoding paths.
Additional whitespace check:
Expected outcome: no output and exit code
0.Docs
No docs change needed. This is an input decoding bug fix for existing Cursor hook behavior and is covered by regression tests.
Notes
Draft PR for focused review and CI validation.