Skip to content

Add agent-v1 shell command attribution#1636

Open
Siddhant-K-code wants to merge 1 commit into
git-ai-project:mainfrom
Siddhant-K-code:siddhant/1313-agent-v1-shell-attribution
Open

Add agent-v1 shell command attribution#1636
Siddhant-K-code wants to merge 1 commit into
git-ai-project:mainfrom
Siddhant-K-code:siddhant/1313-agent-v1-shell-attribution

Conversation

@Siddhant-K-code

@Siddhant-K-code Siddhant-K-code commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add pre_shell_command and post_shell_command payloads to the agent-v1 preset
  • Map those payloads onto the existing PreBashCall/PostBashCall stat-diff flow
  • Add parser/unit coverage and an integration scenario for shell-generated file changes

Fixes #1313.

Validation

Run from the repo root on this branch:

task fmt
task lint
task test TEST_FILTER=agent_v1

Expected outcomes:

  • task fmt exits cleanly with no rustfmt diffs.
  • task lint exits cleanly with no clippy/lint failures.
  • task test TEST_FILTER=agent_v1 passes the agent-v1 parser tests and the shell-command e2e regression.
  • test_agent_v1_shell_command_e2e_attribution creates a shell-generated line, commits it, and verifies the committed/blame view treats that line as AI-authored.

Additional whitespace check:

git diff --check origin/main..siddhant/1313-agent-v1-shell-attribution

Expected outcome: no output and exit code 0.

Docs

No docs change needed. This is a hook payload compatibility addition for the agent-v1 integration and is covered by parser and integration tests.

Notes

PR for focused review and CI validation.

@Siddhant-K-code Siddhant-K-code force-pushed the siddhant/1313-agent-v1-shell-attribution branch from 8af1d9e to 4c29e4a Compare June 24, 2026 11:20
@Siddhant-K-code Siddhant-K-code marked this pull request as ready for review June 24, 2026 12:57

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

agent-v1 protocol lacks support for shell command attribution

1 participant