[codex] Exclude ignored files from telemetry stats#1628
Open
svarlamov wants to merge 1 commit into
Open
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
woud420
approved these changes
Jun 24, 2026
| Some(commit.summary().unwrap_or_default().to_string()), | ||
| Some(commit.body().unwrap_or_default().to_string()), | ||
| ), | ||
| Err(_) => (None, None), |
Collaborator
There was a problem hiding this comment.
nit : worth a trace here?
| .commit_sha(commit_sha) | ||
| .base_commit_sha(parent_sha); | ||
|
|
||
| // Get repo URL from default remote |
Collaborator
There was a problem hiding this comment.
nit : might be worth to put the whole condition in a function for debug traces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.git-ai-ignorematches, and linguist-generated files.Why
Commit stats and telemetry can otherwise overcount large ignored/generated changes, especially deletion-heavy commits where ignored files previously contributed to the expensive stats preflight estimate.
Validation
task fmttask linttask buildgit diff --checktask test TEST_FILTER=test_committed_metric_values_use_filtered_stats_and_hunks_payloadtask test TEST_FILTER=test_commit_hunks_post_commit_path_respects_all_ignore_sourcestask test TEST_FILTER=test_post_commit_large_ignored_deletions_do_not_trigger_skip_warningtask test TEST_FILTER=test_parse_diff_added_lines_with_insertions