Consolidate several L4 OVN ACLs into smaller number of OVN ACLs #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxiaobin
force-pushed
the
us_acl_optimize
branch
4 times, most recently
from
e4cfc4f to
f1dfc82
Compare
jxiaobin
force-pushed
the
us_acl_optimize
branch
7 times, most recently
from
132f993 to
d4c95f7
Compare
jxiaobin
force-pushed
the
us_acl_optimize
branch
5 times, most recently
from
86d0471 to
05c1272
Compare
If an ingress rule has 5 TCP port specified along with a namespace
selector, then we end up creating 5 OVN ACLs. Instead, we could create
just one ACL by consoldiating the individual ports and/or ranges. For
example:
With this Network Policy,
spec:
ingress:
- from:
- nameSelector:
matchLabels:
name: web
ports:
- protocol: TCP
port: 3306
- protocol: TCP
port: 80
- protocol: TCP
port: 9000
endPort: 9100
we end up creating following 3 matches
(ip4.src == {$as1} && tcp && tcp.dst==3306 && outport == @pg1)
(ip4.src == {$as1} && tcp && tcp.dst==80 && outport == @pg1)
(ip4.src == {$as1} && tcp && 9000<=tcp.dst<=9100 && outport == @pg1)
With the fix in this commit, we will have only one match
(ip4.src == {$as1} && tcp && (tcp.dst=={3306,80} || \
9000<=tcp.dst<=9100 && outport == @pg1)
With reduced number of OVN ACLs will result in fewer logical flows
and few OpenFlow flows
Signed-off-by: Xiaobin Qu <[email protected]>
Co-authored-by: Girish Moodalbail <[email protected]>
jxiaobin
force-pushed
the
us_acl_optimize
branch
from
05c1272 to
d9935d0
Compare
girishmg
force-pushed
the
master
branch
3 times, most recently
from
4d44be0 to
5044c18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an ingress rule has 5 TCP port specified along with a namespace
selector, then we end up creating 5 OVN ACLs. Instead, we could create
just one ACL by consoldiating the individual ports and/or ranges. For
example:
With this Network Policy,
spec:
ingress:
- from:
- nameSelector:
matchLabels:
name: web
ports:
- protocol: TCP
port: 3306
- protocol: TCP
port: 80
- protocol: TCP
port: 9000
endPort: 9100
we end up creating following 3 matches
(ip4.src == {$as1} && tcp && tcp.dst==3306 && outport == @pg1)
(ip4.src == {$as1} && tcp && tcp.dst==80 && outport == @pg1)
(ip4.src == {$as1} && tcp && 9000<=tcp.dst<=9100 && outport == @pg1)
With the fix in this commit, we will have only one match
(ip4.src == {$as1} && tcp && (tcp.dst=={3306,80} ||
9000<=tcp.dst<=9100 && outport == @pg1)
With reduced number of OVN ACLs will result in fewer logical flows
and few OpenFlow flows
Signed-off-by: Girish Moodalbail [email protected]