Remove sqlalchemy-utils #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
gianchub
commented
Dec 10, 2025
gianchub
commented
- Remove sqlalchemy-utils dependency
- Add our own functions to create, drop and check if a database exists
- Add tests for those functions
- Some scaffolding.
- Introduced a new test suite for the db_util module, covering functions such as _get_postgres_admin_uri, _get_sqlite_file_path, create_database, and database_exists. - Enhanced _get_postgres_admin_uri to handle cases where the port is not specified. - Updated _get_sqlite_file_path to return None for empty paths and improved handling of edge cases.
- Simplified assertions in the test suite for database existence by removing explicit comparisons to True/False, enhancing readability. - Updated tests for PostgreSQL and SQLite to use more concise assertion styles.
- Added assertions to verify the existence of the in-memory SQLite database after creation. - Improved clarity of the test by ensuring checks are performed before and after the database creation.
- Removed redundant import of create_engine from within the test method. - Consolidated import statements for improved readability and organization.
- Adjusted the test for creating an in-memory SQLite database to assert that it exists after the creation call, reflecting the behavior of in-memory databases. - Improved clarity by adding comments to explain the assertions and their expected outcomes.
mmcardle
previously approved these changes
Dec 10, 2025
Collaborator
mmcardle
left a comment
mmcardle
left a comment
There was a problem hiding this comment.
Im aware most of the code changes come from copied code from sqlalchemy-utils so happy to approve as is without the changes i have commented on.
gianchub
force-pushed
the
remove-utils
branch
from
602cd3f to
053026e
Compare
mmcardle
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.