Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new bucket utilities #68

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Add new bucket utilities #68

wants to merge 36 commits into from

Conversation

ghiggi
Copy link
Owner

@ghiggi ghiggi commented Sep 4, 2024

Prework

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Tutorial
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and communicate accordingly:

The PR fulfills these requirements:

  • It's submitted to the branch named as follow:
    • Fix a bug: bugfix-<some_key>-<word>
    • Improve the doc: doc-<some_key>-<word>
    • Improve a tutorial tutorial-<some_key>-<word>
    • Add a new feature: feature-<some_key>-<word>
    • Refactor some code: refactor-<some_key>-<word>
    • Optimize some code: optimize-<some_key>-<word>
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • Don't forget to link PR to issue if you are solving one.
  • All tests are passing.
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Related GitHub issues and pull requests

  • Ref: #

Summary

Please explain the purpose and scope of your contribution.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 24.32432% with 84 lines in your changes missing coverage. Please review.

Project coverage is 93.93%. Comparing base (5f030ab) to head (a69dca5).

Files with missing lines Patch % Lines
gpm/bucket/analysis.py 0.00% 50 Missing ⚠️
gpm/dataset/crs.py 0.00% 16 Missing ⚠️
gpm/visualization/facetgrid.py 30.00% 14 Missing ⚠️
gpm/visualization/plot.py 84.21% 3 Missing ⚠️
gpm/utils/checks.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   94.43%   93.93%   -0.50%     
==========================================
  Files         134      127       -7     
  Lines       15404    15318      -86     
==========================================
- Hits        14546    14389     -157     
- Misses        858      929      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Sep 4, 2024

Coverage Status

coverage: 93.935% (-0.5%) from 94.43%
when pulling a69dca5 on add-misc
into 5f030ab on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants