Angular 4 Data Table Compile issue (/node_modules/angular-4-data-table/src/index.ts) #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding ellipses in page numbers
Seperate page number links in pagination
… data to display in the table. The column spans the full length of the table. It only displays when the itemCount is 0 and the user passed a noDataMessage to the component. There is a new Input to the table called noDataMessage.
Ability to Display a "No Data" Message in the Table
- sortable column headers have `tabIndex` set - sortable column headers have proper `aria-sorting` attribute - sorting can be triggered via `Space` or `Enter` keys
- row.template's expand row is a focusable `button`. It includes `aria-expanded`, `title` and `aria-label` also. - header.template: added missing`aria-label`s and `title`s for buttons. - table.template: added `aria-label` attribute for _select_ column. - added missing translations (note: demo page should be fixed as well)
aot compatiable changes
add basic accessibility support.
Fixed typos
aot compatible changes in row.component.ts file
|
Let me know the the issue is fixed or not.If it is fixed how to fix the issue from end. |
aot compatible changes in table.component.ts
aot compatible changes
aot compatiable changes in getRowColor method.
aot changes in table.component.ts
|
hi, locally angular-2-data-table work properly but when i m creating production build , it is not working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
iam getting the below error message when i follow the instructions link
https://www.npmjs.com/package/angular-4-data-table-aot
Iam not sure what is wrong simply i have added the module in the app.moudule file.
Note : Used AngularCLI :1.5.2
Any one can suggest how to fix the issue asp.
Code.zip
Attached code files for your reference.
Error message:
=====================================
ERROR in ./node_modules/angular-4-data-table/src/index.ts
Module build failed: Error: C:\AMD\Examples\Angular4\Grid\Samples\A4DataTable\node_modules\angular-4-data-table\src\index.ts is not part of the compilation output. Please check the other error messages for details.
at AngularCompilerPlugin.getCompiledFile (C:\Examples\Angular4\Grid\Samples\A4DataTable\node_modules@ngtools\webpack\src\angular_compiler_plugin.js:624:23)
at plugin.done.then (C:\Examples\Angular4\Grid\Samples\A4DataTable\node_modules@ngtools\webpack\src\loader.js:467:39)
at
at process._tickCallback (internal/process/next_tick.js:169:7)
@ ./src/app/app.module.ts 10:0-65
@ ./src/main.ts
@ multi webpack-dev-server/client?http://0.0.0.0:0 ./src/main.ts