docker : add configurable port support for health checking #15943
+31
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When "docker run -e LLAMA_ARG_PORT=8088", the container health status is always '(unhealthy)', since the command is fixed as "http://localhost:8080/health". Use the enviroment value 'LLAMA_ARG_PORT' to start health checking to avoid this problem.
github-actions
bot
added
the
devops
|
Why would you use the |
|
Same question as @taronaeo Most dockerfiles that I know have quite simple |
xuanson2025
reviewed
Sep 13, 2025
| @@ -0,0 +1,3 @@ | |||
| #!/bin/sh | |||
|
|
|||
| curl -f "http://localhost:${LLAMA_ARG_PORT:-8080}/health" | |||
There was a problem hiding this comment.
The exit code doesn't seem to be forwarded. This will cause the script to always report success result even when it isn't
Thanks, yes, "-p 80:8080" is a good practice. Make sense to keep thing simple @xuanson2025 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "docker run -e LLAMA_ARG_PORT=8088", the container health status is always '(unhealthy)', since the command is fixed as "http://localhost:8080/health".
Use the enviroment value 'LLAMA_ARG_PORT' to start health checking to avoid this problem.
Make sure to read the contributing guidelines before submitting a PR