Skip to content

vulkan/cuda: Fix im2col when KW!=KH #14789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

Conversation

jeffbolznv
Copy link
Collaborator

@jeffbolznv jeffbolznv commented Jul 21, 2025

The tid is decomposed into ow + ky*OW + kx*OW*KH. Change ksize to match.

Fixes #14777.

The tid is decomposed into "ow + ky*OW + kx*OW*KH". Change "ksize" to match.
@github-actions github-actions bot added testing Everything test related Nvidia GPU Issues specific to Nvidia GPUs Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Jul 21, 2025
@jeffbolznv
Copy link
Collaborator Author

CC @etasnadi

Copy link
Collaborator

@0cc4m 0cc4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this fixes the issue on Vulkan and CUDA.

@0cc4m 0cc4m merged commit c2e058f into ggml-org:master Jul 21, 2025
47 checks passed
@Rbiessy Rbiessy mentioned this pull request Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ggml changes relating to the ggml tensor library for machine learning Nvidia GPU Issues specific to Nvidia GPUs testing Everything test related Vulkan Issues specific to the Vulkan backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misc. bug: test-backend-ops: IM2COL test sometimes fail with when KW!=KH
3 participants