-
Notifications
You must be signed in to change notification settings - Fork 12.2k
ggml : implement GEGLU_ERF and GEGLU_QUICK ops #14445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SYCL code LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vulkan code looks fine. I wonder how much precision erf needs and if we could just handcode something in the Vulkan shader.
The following seems to work for Metal, so should be good enough for Vulkan: llama.cpp/ggml/src/ggml-metal/ggml-metal.metal Lines 1099 to 1115 in 38593bc
Edit: I'll give it a try. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Vulkan code works on all of my devices.
@CISC OpenCL looks good and works for me. |
Complimentary to the other GLU ops, used in
mtmd
.Implemented for all currently GLU supported backends,
except GEGLU_ERF in Vulkan due to missing.erf