-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Added CI with RISC-V RVV1.0 Hardware #14439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Still refactoring. |
I have updated the CI file in the repository to run on real RISC-V hardware with RVV 1.0, instead of using QEMU. A working CI log on RISC-V Jupiter board can be seen here. @ggerganov Your credentials were already added, you just have to add a webhook for the project (unless the credentials have expired). Webhook was previously disabled somehow. It would be great if you could add the webhook again. You will just have to add the following details to the webhook settings of the repository. In the events, select Pull requests and Pushes. Once you have added this, I will try to test by creating a PR (which I will close later if the build is triggering). |
Reference PR: #3160 |
Bumping this PR for adding CI on RISC-V. |
I have now added a github CI instead of Jenkins for RISC-V vector. You will just have to go to this link and add the github runner token with the repository URL. The compute machine This does not require Jenkinsfile to be merged; github CI will run using github actions/workflows. |
@alitariq4589 How to obtain a "Github Runner Token"? |
Thanks. I have completed the registration of the runner in cloud-v. Anything else needed on my side? |
Thanks. I can see it is registered in the database. There is nothing needed from your side at the moment. I will delete the Jenkinsfile, which was previously added for Cloud-V for QEMU, and then will add a GitHub Actions file for compilation and running on RISC-V. Once that is done, this PR will have to be merged. |
I think you may have added the expired token. I am getting an authentication error inside GitHub Actions.
I am removing this registration. Can you please add it again? |
Just to make sure - do I need to actually create the runner in the Github settings, or just to copy the token from the page? |
@ggerganov You just have to copy the repo link and token and paste it in the fields on the page https://cloud-v.co/github-riscv-runner and submit. I don't exactly know how long the token is valid for github, but if it has expired, then we get the same kind of error as I posted above. |
Should be good now - can you confirm? |
I am getting the same error again inside the logs. This is strange. I never got this error from any registration before if the token is valid. Let me quickly check manually if I can curl through the token and repository URL. |
From what I can see in the curl output, there is some issue with how the token is generated.
According to github documentation for rest api:
|
Can you do the following to check if the token you are generating is valid from your side? As I have read from the docs, the token is valid for 1hour. You can also generate a PAT with repository scope and check if that works. Get the github actions package from your end (linux-x64):
You can try the following commands to check if the token you are generating is valid. PAT is different from the github runner token.
Please let me know what you get from this. As I have checked, I can register the repositories from my side without any issue. If I remember it correctly I had an issue with the generated token in the past too. Maybe there is something different with how the tokens are generated in llama.cpp repo? 🤔 |
Doing these instructions worked. Let me try to recreate using the token from the Please remove the old registration so I can create a new one. |
That explains the issue. I am outside right now. I will message you after removing the token after a while. (Hopefully this will work out this time. And sorry for prolonged setup issue 😅) |
@ggerganov, I have removed the runner. You can add the token. Be sure to add the token of repo scope instead of organization scope, as I have not yet added any organization-specific functionality. |
ETA 30 min (afk atm) |
No worries |
@alitariq4589 Should be up now. |
Thanks a lot @ggerganov and sorry for taking your time It's working now. I will now be moving to workflow part. BTW, if you need anything RISC-V related, let me know.
|
No problem and thank you for providing hardware for the CI - appreciated! |
…ctions workflow Removed the legacy .devops/cloud-v-pipeline Jenkins CI configuration and introduced .github/workflows/build-riscv-native.yml for native RISC-V builds using GitHub Actions.
Replace Jenkins Cloud-V pipeline with GitHub Actions RISC-V native build
@ggerganov The workflow file is added. @akifejaz has replicated an already-added CI file according to RISC-V and removed the old cloud-v-pipeline file. Now, the CI should run on riscv on pull request creation. You'll be able to merge this now. |
This reverts commit 648ebcd.
I have added the RISC-V CI for running RISC-V RVV 1.0 hardware