Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: include folder and common folder is private to llama library #11631

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mofosyne
Copy link
Collaborator

@mofosyne mofosyne commented Feb 3, 2025

Issue Ticket: #11630

@mofosyne
Copy link
Collaborator Author

mofosyne commented Feb 3, 2025

Not as familiar with CMake, but looks like this change doesn't quite work.

@slaren
Copy link
Collaborator

slaren commented Feb 3, 2025

The public directory still needs to be public. Some examples may depend on the llama targeting adding the src and common to the include directories, and will need to be adjusted. Some tests use headers from src because they need the lower level access to llama.cpp. That's ok, but they need to add the include directory themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants