HIP: force max threads per block to be 1024 #11621
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ggml
IMbackK
reviewed
Feb 3, 2025
ggml/src/ggml-hip/CMakeLists.txt
Outdated
| @@ -40,6 +40,9 @@ find_package(hip REQUIRED) | |||
| find_package(hipblas REQUIRED) | |||
| find_package(rocblas REQUIRED) | |||
|
|
|||
| # Workaround old compilers | |||
There was a problem hiding this comment.
please move this down a bit as the find_package calls and the version check below are logically related operations
|
I saw the discussion, but don't have any knowledge about HIP/ROCm to have an opinion about this. If you think that it is not likely to cause issues to other users, feel free to merge it. |
Some old compilers still use 256. Explicitly set it to 1024 to get correct result from ops like ARGMAX and GROUP_NORM. Related: ggerganov#10610, ggerganov#11619 Signed-off-by: fxzjshm <[email protected]>
fxzjshm
force-pushed
the
hip-launch_bounds
branch
from
7e596d4 to
59ad593
Compare
|
@IMbackK Moved. Is this place proper? @slaren This compiler flag is documented at https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-gpu-max-threads-per-block. I've also compiled with ROCm 6.3.1 and no compile error is given, now testing test-backend-ops. Update: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some old compilers still use 256. Explicitly set it to 1024 to get correct result from ops like ARGMAX and GROUP_NORM.
Related: #10610, #11619
CC @IMbackK