-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tool-call
: fix DeepSeek R1 Qwen distills
#11607
Open
ochafik
wants to merge
55
commits into
ggerganov:master
Choose a base branch
from
ochafik:r1-toolcall
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+639
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le tool call delta!)
github-actions
bot
added
testing
Everything test related
examples
python
python script changes
server
labels
Feb 3, 2025
41 tasks
This was referenced Feb 3, 2025
…s, explicitly skipped in new template options
Open
ochafik
changed the title
Feb 4, 2025
tool-call
: fix DeepSeek R1 Qwen distill (WIP)tool-call
: fix DeepSeek R1 Qwen distill
ochafik
changed the title
Feb 4, 2025
tool-call
: fix DeepSeek R1 Qwen distilltool-call
: fix DeepSeek R1 Qwen distills
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tool call support of DeepSeek-R1-Distill-Qwen-7B & 32B (follow up to #9639), and adds
<think>
thoughts</think>
parsing.(Split off Minja changes in #11641, will declutter diff once merged)
sync
: minja #11641<|tool▁outputs▁end|>
instead of ending with<|end▁of▁sentence|><|Assistant|>
).models/templates/llama-cpp-deepseek-r1.jinja
)<think>
content to the API similar to the "tool_plan" output oftool-call
: support Command R7B (+ return tool_plan "thoughts" in API) #11585TODOs:
tool-call
: allow--chat-template chatml
w/--jinja
, default to chatml upon parsing issue, avoid double bos #11616)tool-call
: command r7b fix for normal responses #11608)Possible follow ups