WGSL parsing for mesh shaders #8370
Conversation
Co-authored-by: Jim Blandy <[email protected]>
| /// | ||
| /// [`enable clip_distances;`]: https://www.w3.org/TR/WGSL/#extension-clip_distances | ||
| ClipDistances, | ||
| /// Enables the `mesh_shader` extension, native only |
There was a problem hiding this comment.
thought: I wonder if it'd be an easier diagnostic experience across the board (esp. with bug reports in places not immediately related to wgpu) to have a naga_* prefix for Naga-specific extensions.
There was a problem hiding this comment.
@cwfitzgerald thoughts?
naga/src/ir/mod.rs
Outdated
| PointCoord, | ||
| FrontFacing, | ||
| PrimitiveIndex, | ||
| PrimitiveIndex, // Also for mesh output |
There was a problem hiding this comment.
suggestion: Shall we turn this and the other small comments around it into doc commenta instead? They seem like helpful notes in a maintainer's or dev.'s experience, not just somebody who happens to be looking at this code.
There was a problem hiding this comment.
I've added some docs to this, let me know what you think (FYI the changes related to IR and docs are mostly in #8104. The only point of this PR is to add a WGSL parser)
|
Wow, thanks for looking at this so quickly @ErichDonGubler! Very good comments over-all. |
Co-authored-by: Erich Gubler <[email protected]>
Co-authored-by: Erich Gubler <[email protected]>
Co-authored-by: Erich Gubler <[email protected]>
4 participants
Connections
Depends on & used to test #8104
Description
Adds WGSL parsing for mesh shaders to naga.
This builds on #8104, and many of the changes here come from that PR.
Testing
There are mesh shader tests (that don't actually write to any backend)
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.