Skip to content

Conversation

@inner-daemons
Copy link
Collaborator

@inner-daemons inner-daemons commented Sep 10, 2025

Connections
Closes #7196
Closes #8138

Description
Adds new limits and testing for multiview, add support for more backends (also in naga), add new multiview bitmask renderpass descriptor field for selecting which layers to render to in a single pass.

Testing
There are tests

Squash or Rebase?
Squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@inner-daemons inner-daemons marked this pull request as ready for review September 10, 2025 20:10
@inner-daemons inner-daemons marked this pull request as draft September 11, 2025 18:38
@inner-daemons inner-daemons requested review from cwfitzgerald and removed request for cwfitzgerald September 11, 2025 18:38
@inner-daemons
Copy link
Collaborator Author

inner-daemons commented Sep 12, 2025

@cwfitzgerald I left a comment about this in matrix but it got hidden by newer messages. Is it a bad idea to add another multi view related field to a render pass descriptor? This might be a topic worth bringing up in a meeting, I'm not sure. I'm just hesitant to assume that's fine because if I'm wrong then I will have refactored every use of render passes in this entire repo :)

Not urgent of course

EDIT: This has been answered

@inner-daemons inner-daemons mentioned this pull request Sep 15, 2025
8 tasks
@inner-daemons
Copy link
Collaborator Author

My web UI doesn't have an "add suggestion to batch" right now for whatever reason. I'm gonna commit everything individually lol since I couldn't figure this out.

@inner-daemons
Copy link
Collaborator Author

@Wumpf Thanks for the review! This this incredibly comprehensive and useful. I'll probably just rewrite major parts of the test/example, since that seems to be the weakest part.

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for following up on everything! example & test looks a lot nicer now :)
However, I believe you made a mistake and accidentally made the non-continguous mask-test continguous

But I think after that we're done! :)

@inner-daemons
Copy link
Collaborator Author

@Wumpf Great, thanks! Should be good to go soon then

@inner-daemons
Copy link
Collaborator Author

Feature detection is currently broken, gonna look that over and unbreak this bad diff resolution. Then it should be pretty good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Limits and validation for multiview Tests for multiview support

4 participants