- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.1k
Add multiview limits and tests #8206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Add multiview limits and tests #8206
Conversation
| @cwfitzgerald I left a comment about this in matrix but it got hidden by newer messages. Is it a bad idea to add another multi view related field to a render pass descriptor? This might be a topic worth bringing up in a meeting, I'm not sure. I'm just hesitant to assume that's fine because if I'm wrong then I will have refactored every use of render passes in this entire repo :) Not urgent of course EDIT: This has been answered | 
…ue to bitmask limitation
…amples multiview fields
| My web UI doesn't have an "add suggestion to batch" right now for whatever reason. I'm gonna commit everything individually lol since I couldn't figure this out. | 
Co-authored-by: Andreas Reich <[email protected]>
Co-authored-by: Andreas Reich <[email protected]>
Co-authored-by: Andreas Reich <[email protected]>
Co-authored-by: Andreas Reich <[email protected]>
Co-authored-by: Andreas Reich <[email protected]>
| @Wumpf Thanks for the review! This this incredibly comprehensive and useful. I'll probably just rewrite major parts of the test/example, since that seems to be the weakest part. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for following up on everything! example & test looks a lot nicer now :)
However, I believe you made a mistake and accidentally made the non-continguous mask-test continguous
But I think after that we're done! :)
Co-authored-by: Andreas Reich <[email protected]>
| @Wumpf Great, thanks! Should be good to go soon then | 
| Feature detection is currently broken, gonna look that over and unbreak this bad diff resolution. Then it should be pretty good | 
Connections
Closes #7196
Closes #8138
Description
Adds new limits and testing for multiview, add support for more backends (also in naga), add new multiview bitmask renderpass descriptor field for selecting which layers to render to in a single pass.
Testing
There are tests
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.