Skip to content

add into_custom api for Instance Queue, and Device #7840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mikialex
Copy link

Connections

related issue: #7714 and specific discussion: #7714 (comment)

Description

This PR adds util methods to convert some wgpu-level api into its internal custom one. Currently, only for Instance, Queue and Device, as these are the most common places to inject custom logic.

Testing

The change is simple to verify.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@mikialex mikialex requested a review from a team as a code owner June 23, 2025 08:03
Copy link
Contributor

@nical nical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The motivations you presented for this are already covered by a different API. You should extend the internal counters if you are missing information.

@sagudev
Copy link
Collaborator

sagudev commented Jun 24, 2025

The motivations you presented for this are already covered by a different API. You should extend the internal counters if you are missing information.

Actually I can see how something like this could be useful for someone that wants to create wrapper (custom backend) for wgpu types, but does not need to wrap/override all, just some of them. The question is whether we are willing to offer them this shortcut.

@cwfitzgerald
Copy link
Member

@nical could you follow up on this?

@nical
Copy link
Contributor

nical commented Jul 23, 2025

I am very sorry for the delay. For now we want to be cautious about how much we expose and how much API surface we add, so we decided to not add this.
If you want to create a custom device you'll have to make a custom wrapper backend that wraps all objects as sagudev suggested.

@nical nical closed this Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants