CI: add cargo hack check

.github/workflows/ci.yml

@@ -77,7 +77,8 @@ jobs:
     #
     # currently high due to documentation time problems on mac.
     # https://github.com/rust-lang/rust/issues/114891
-    timeout-minutes: 30
+    # XXX TBD ??? - increased further to avoid interrupting cargo hack
+    timeout-minutes: 90
 
     strategy:
       fail-fast: false
@@ -175,6 +176,12 @@ jobs:
             tier: 2
             kind: no_std
 
+          - name: hack check - Linux x86_64
+            os: ubuntu-22.04
+            target: x86_64-unknown-linux-gnu
+            tier: 1
+            kind: hack
+
     name: Clippy ${{ matrix.name }}
     runs-on: ${{ matrix.os }}
 
@@ -288,6 +295,21 @@ jobs:
           # Check with all features except "std".
           cargo clippy --target ${{ matrix.target }} ${{ matrix.extra-flags }} -p wgpu-types --no-default-features --features strict_asserts,fragile-send-sync-non-atomic-wasm,serde,counters
 
+      - name: hack check
+        if: matrix.kind == 'hack'
+        shell: bash
+        run: |
+          set -e
+
+          # install cargo-hack
+          cargo install cargo-hack
+
+          # hack check each feature
+          cargo hack --workspace --feature-powerset --depth 1 clippy
+        env:
+          # XXX TBD ???
+          RUSTFLAGS: ""
+
       # Building for native platforms with standard tests.
       - name: check native
         if: matrix.kind == 'native'

wgpu-core/src/instance.rs

@@ -3,6 +3,8 @@ use std::sync::Arc;
 
 use hashbrown::HashMap;
 
+// XXX TODO MORE FOCUSED allow directive
+#[allow(unused_imports)]
 use crate::{
     api_log, api_log_debug,
     device::{queue::Queue, resource::Device, DeviceDescriptor, DeviceError},

wgpu-core/src/lock/rank.rs

@@ -141,6 +141,7 @@ define_lock_ranks! {
     rank REGISTRY_STORAGE "Registry::storage" followed by { }
     rank RESOURCE_POOL_INNER "ResourcePool::inner" followed by { }
     rank SHARED_TRACKER_INDEX_ALLOCATOR_INNER "SharedTrackerIndexAllocator::inner" followed by { }
+    #[allow(dead_code)]
     rank SURFACE_PRESENTATION "Surface::presentation" followed by { }
     rank TEXTURE_BIND_GROUPS "Texture::bind_groups" followed by { }
     rank TEXTURE_INITIALIZATION_STATUS "Texture::initialization_status" followed by { }