Avoid using the std::intrinsics module #803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is actually unstable but [there's a bug][bug] in the compiler allowing it to be used. Good news is that these functions are available stable elsewhere! [bug]: rust-lang/rust#28075
|
Wow, Alex here! Welcome, and thanks for the PR! @homu r+ |
|
📌 Commit 272dc46 has been approved by |
homu
added a commit
that referenced
this pull request
Sep 18, 2015
Avoid using the std::intrinsics module This is actually unstable but [there's a bug][bug] in the compiler allowing it to be used. Good news is that these functions are available stable elsewhere! [bug]: rust-lang/rust#28075
|
☀️ Test successful - status |
|
❤️ |
|
Ah and also, would you be ok releasing a new version with this change? I'm hoping to do a crater run with this release to further evaluate the impact of rust-lang/rust#28364 |
|
@alexcrichton sure! @csherratt is on it |
|
Awesome, thanks! |
|
@alexcrichton it's published now. Cheers! |
|
Thanks @csherratt! |
adamnemecek
pushed a commit
to adamnemecek/gfx
that referenced
this pull request
Apr 1, 2021
803: Player-based GPU test framework r=cwfitzgerald a=kvark **Connections** Closes gfx-rs#786 **Description** This change adds a GPU-based testing by re-using the Player from tracing infrastructure - gfx-rs#289. It converts the player into a lib + binary, and adds an integration test into the crate that implements RON-specified testing. Current implementation has a few requirements/gotchas that are listed in `test.rs`: * in all the IDs, the backend is `Empty` * all expected buffers have `MAP_READ` usage on them * last action is `Submit` I believe it's workable, and we can improve it down the road (e.g. with gfx-rs#792). **Testing** MUHAHAHA `cargo test` nails it Co-authored-by: Dzmitry Malyshau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually unstable but there's a bug in the compiler allowing it
to be used. Good news is that these functions are available stable elsewhere!