Retrieved sources via GET instead of HEAD#138
Merged
EbonJaeger merged 1 commit intomainfrom Jan 16, 2026
Merged
Conversation
Let `grab` follow the redirects with the `GET` method directly instead of manually resolving them via `HEAD`. This works around an issue where `HEAD` would result in a redirect URL that is not valid using `GET` seen on the freedesktop.org GitLab instance.
Member
Author
|
Tested this for a sourceforge source as that was the original reason for the HEAD requests. It still works, but is a bit more verbose: |
EbonJaeger
approved these changes
Jan 16, 2026
Member
EbonJaeger
left a comment
EbonJaeger
left a comment
There was a problem hiding this comment.
LGTM, thanks! This makes downloading uploaded release assets from GitLab work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let
grabfollow the redirects with theGETmethod directly instead of manually resolving them viaHEAD.This works around an issue where
HEADwould result in a redirect URL that is not valid usingGETseen on the freedesktop.org GitLab instance.