ingest-router: synapse adds the upstream url to project config #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivations for this change: - synapse should own this topology - since synapse is already aware of it upstreams, while sentry and other relays never need to know their downstreams or their own addresses - avoids the need for the relay urls to be configured in multiple places and kept in sync manually - the upstream url is only needed in multi-cell scenarios. this ensures that it is only added when synapse is involved and self-hosted and single-cell regions remain unchanged without this field - derisks rollout, enables the original ingestion path to be unchanged while synapse/ new ingestion path can run side by side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivations for this change: