ingest-router: publickeys endpoint #107
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Jan 9, 2026
Comment on lines
+89
to
+105
| // Extract requested relay_ids from the request | ||
| let request_data: PublicKeysRequest = deserialize_body(body.clone())?; | ||
| let requested_relay_ids: HashSet<String> = request_data.relay_ids.into_iter().collect(); | ||
|
|
||
| // Send the request to all cells | ||
| let cell_requests = cells | ||
| .cell_list() | ||
| .iter() | ||
| .map(|cell_id| { | ||
| let req = Request::from_parts(parts.clone(), body.clone()); | ||
| (cell_id.clone(), req) | ||
| }) | ||
| .collect(); | ||
|
|
||
| let metadata = Box::new(PublicKeysMetadata { | ||
| requested_relay_ids, | ||
| }); |
Member
There was a problem hiding this comment.
I don't think we need to do a fanout here. We could fetch from any cell instead. We'll be replicating the data that this endpoint reads into all cells as part of relay's registration flows.
Member
Author
There was a problem hiding this comment.
alright. that makes things easier
did it that way in #109
lynnagara
added a commit
that referenced
this pull request
Jan 9, 2026
alternative to #107 with this option, sentry replicates the data so AnyCellHandler is fine as each cell returns a complete result
lynnagara
added a commit
that referenced
this pull request
Jan 9, 2026
alternative to #107 with this option, sentry replicates the data so AnyCellHandler is fine as each cell returns a complete result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this endpoint implements a fanout and merge strategy.
unlike project configs, partial responses are not really valid, so we only return a successful merged response under two conditions: