ingest-router: add admin service #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move the ingest router service out of lib.rs to it's own module - add the admin service - this mirrors the implementation in the proxy
lynnagara
commented
Jan 7, 2026
| @@ -0,0 +1,193 @@ | |||
| use crate::config; | |||
Member
Author
There was a problem hiding this comment.
this code is not new -- just moved from lib.rs
markstory
approved these changes
Jan 8, 2026
| pub fn new(is_ready: F) -> Self { | ||
| Self { | ||
| is_ready, | ||
| _error: PhantomData, |
Member
There was a problem hiding this comment.
What is this used for? I don't see any other references to it.
Member
Author
There was a problem hiding this comment.
only to keep the type system happy since the service is generic over E, which is either IngestRouterError or ProxyError depending on where it's used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/sharedso ingest-router can reuse the implementation