Skip to content

proxy: fix invalid example config #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lynnagara merged 3 commits into from
Jan 7, 2026
Merged

proxy: fix invalid example config #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bbbf48
proxy: fix invalid example config
lynnagara Jan 6, 2026
3e252a0
revert
lynnagara Jan 7, 2026
290d561
Merge remote-tracking branch 'origin/main' into fix-proxy-example-config
lynnagara Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion example_config_proxy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ proxy:
us2: us2-conduit
- match:
host: conduit.de.sentry.io
path: /organizations/{organization}/*
action:
to: de-conduit

Expand Down
10 changes: 4 additions & 6 deletions proxy/src/route_actions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,9 @@ impl TryFrom<RouteConfig> for Route {
s.strip_prefix('{').and_then(|s| s.strip_suffix('}'))
{
if is_static_action {
return Err(ProxyError::InvalidRoute(
"Dynamic path parameters are not allowed with static actions"
.to_string(),
));
return Err(ProxyError::InvalidRoute(format!(
"Dynamic path parameters are not allowed with static actions in route: {path_str}"
)));
}
let is_valid = stripped.chars().all(|ch| ch.is_ascii_lowercase() || ch == '_' );
if !is_valid {
Expand All @@ -136,8 +135,7 @@ impl TryFrom<RouteConfig> for Route {

if !is_valid {
return Err(ProxyError::InvalidRoute(format!(
"Invalid static segment: {}",
s
"Invalid static segment: {s} in route: {path_str}"
)));
}

Expand Down