Skip to content

ref(examples): Add more examples to tests #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

ref(examples): Add more examples to tests #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
19dc97f
ref(examples): Add more examples to tests
untitaker Jul 18, 2025
8f18496
split up integration tests job
untitaker Jul 21, 2025
0eebcfe
fix up
untitaker Jul 24, 2025
e39dac7
Merge remote-tracking branch 'origin/main' into wip/more-example-tests
untitaker Aug 12, 2025
dfdfb01
move to localbroker
untitaker Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,32 +30,3 @@ jobs:
run: make tests-flink
env:
FLINK_LIBS: ./flink_libs

integration-tests:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep this as a separate CI check, to avoid clutter.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure? to me this is just another kind of test and can be part of tests/

name: "Run integration tests"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v5
with:
python-version-file: sentry_streams/.python-version

- name: Make environment
run: |
make install-dev

- name: Install devservices
run: |
pip install devservices

- name: Start services
id: setup
run: |
devservices up

- name: Install local package
run: |
pip install -e sentry_streams/.

- name: Run integration tests
run: make tests-integration
3 changes: 0 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ tests-streams:
./sentry_streams/.venv/bin/pytest -vv sentry_streams/tests
.PHONY: tests-streams

tests-integration:
./sentry_streams/.venv/bin/pytest -vv sentry_streams/integration_tests
.PHONY: tests-integration

test-rust-streams: tests-rust-streams
.PHONY: test-rust-streams
Expand Down
Empty file removed sentry_streams/integration_tests/__init__.py
View file
Open in desktop
Empty file.
245 changes: 0 additions & 245 deletions sentry_streams/integration_tests/test_example_pipelines.py
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions sentry_streams/sentry_streams/deployment_config/transformer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ pipeline:
myinput:
starts_segment: True
bootstrap_servers:
- "localhost:9092"
- "127.0.0.1:9092"

kafkasink2:
bootstrap_servers:
- "localhost:9092"
- "127.0.0.1:9092"
Loading
Loading