feat(logs): Add view samples button in logs #98133
Merged
+184
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the view samples button in spans.
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
❌ 7 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| return [ | ||
| <Fragment key={`sample-${rowIndex}`}> | ||
| {topEventsLimit && rowIndex < topEventsLimit && ( | ||
| <TopResultsIndicator color={palette[rowIndex]!} /> |
There was a problem hiding this comment.
Bug: Palette Initialization Causes Out-of-Bounds Errors
The palette is initialized with numberOfRowsNeedingColor - 1 elements. This can lead to theme.chart.getColorPalette being called with a negative argument (-1) when numberOfRowsNeedingColor is 0. Additionally, when numberOfRowsNeedingColor equals topEventsLimit, the palette is one element too small, causing an out-of-bounds access when palette[rowIndex]! is used for the last rowIndex.
Dhrumil-Sentry
approved these changes
Aug 26, 2025
k-fish
approved these changes
Aug 26, 2025
| @@ -503,6 +509,49 @@ export function ourlogToJson(ourlog: TraceItemDetailsResponse | undefined): stri | |||
| return JSON.stringify(copy, null, 2); | |||
| } | |||
|
|
|||
| export function viewLogsSamplesTarget({ | |||
There was a problem hiding this comment.
Can we maybe reuse getLogsUrl here?
There was a problem hiding this comment.
we'll think about how to consolidate more of these ways to link to logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the view samples button in spans.