fix(ourlogs): Fix logs widget viewer link #98126
Conversation
Should say 'open in explore' and link to the correct logs page
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| interval: queryParams.interval, | ||
| mode: queryParams.mode, | ||
| }); | ||
| } |
There was a problem hiding this comment.
Bug: Incorrect Parameter Types and Missing Sort
When calling getLogsUrl, the aggregateFields parameter receives queryParams.visualize, which is an array of visualization objects, instead of the expected array of aggregate field strings. This type mismatch may cause incorrect logs URLs. Additionally, the sort parameter from queryParams is omitted, leading to lost sorting functionality.
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
| const traceItemDataset = getTraceItemDatasetFromWidgetType(widget.widgetType); | ||
|
|
||
| if (widget.queries.length > 1) { | ||
| if (traceItemDataset === TraceItemDataset.LOGS) { | ||
| Sentry.captureException( | ||
| new Error( | ||
| `getWidgetExploreUrl: multiple queries for logs is unsupported, widget_id: ${widget.id}, organization_id: ${organization.id}, dashboard_id: ${widget.dashboardId}` | ||
| ) | ||
| ); | ||
| } | ||
| return _getWidgetExploreUrlForMultipleQueries( | ||
| widget, | ||
| dashboardFilters, | ||
| selection, | ||
| organization | ||
| organization, | ||
| traceItemDataset | ||
| ); |
There was a problem hiding this comment.
Potential bug: Logs widgets with multiple queries incorrectly generate a URL for the traces compare view (/explore/traces/compare/) instead of the logs view, misdirecting users.
-
Description: When a dashboard widget for logs contains multiple queries, the
getWidgetExploreUrlfunction calls_getWidgetExploreUrlForMultipleQueries. This function, in turn, usesgetExploreMultiQueryUrl, which is hardcoded to always generate a URL for the traces compare view (/explore/traces/compare/). As a result, clicking 'Open in Explore' on a multi-query logs widget incorrectly navigates the user to the traces comparison tool instead of the logs exploration view, disrupting the user's workflow and leading them to the wrong context. -
Suggested fix: The
_getWidgetExploreUrlForMultipleQueriesfunction should be updated to handle different dataset types. It should check the widget's dataset and call the appropriate URL generation function, such asgetLogsUrlfor logs widgets, instead of always defaulting togetExploreMultiQueryUrlwhich is specific to traces.
severity: 0.65, confidence: 0.95
Did we get this right? 👍 / 👎 to inform future reviews.
| default: | ||
| return TraceItemDataset.SPANS; // Default to spans for backwards compatibility |
There was a problem hiding this comment.
nit: Can we force the caller to handle the backwards compatibility with widgetType ?? WidgetType.SPANS? and throw an error here? This feels like we're likely to introduce subtle bugs in the future.
### Summary Should say 'open in explore' and link to the correct logs page #### Screenshots <img width="1145" height="555" alt="Screenshot 2025-08-22 at 12 03 12 PM" src="https://github.com/user-attachments/assets/1750a00f-7022-4dcc-ba25-115958958776" />
Summary
Should say 'open in explore' and link to the correct logs page
Screenshots