Skip to content

Conversation

ceorourke
Copy link
Member

@ceorourke ceorourke commented Aug 20, 2025

Add a method to app_service to fetch all active (not pending deletion) sentry apps for an organization and a method to update a sentry app. Used for https://github.com/getsentry/getsentry/pull/18204

@ceorourke ceorourke requested review from a team as code owners August 20, 2025 22:31
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 20, 2025
cursor[bot]

This comment was marked as outdated.

@ceorourke ceorourke changed the title feat(sentry apps): Add HC method to fetch sentry apps for an org feat(sentry apps): Add HC methods to fetch sentry apps for an org and update a sentry app Aug 21, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link

codecov bot commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/sentry_apps/services/app/impl.py 85.71% 2 Missing ⚠️
src/sentry/sentry_apps/services/app/service.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #98080      +/-   ##
==========================================
- Coverage   80.73%   80.62%   -0.11%     
==========================================
  Files        8604     8598       -6     
  Lines      381301   379244    -2057     
  Branches    24710    24710              
==========================================
- Hits       307846   305781    -2065     
- Misses      73077    73085       +8     
  Partials      378      378              

@ceorourke ceorourke requested a review from a team August 25, 2025 19:17
@ceorourke ceorourke merged commit d8bc311 into master Aug 26, 2025
64 checks passed
@ceorourke ceorourke deleted the ceourke/get-sentry-apps-for-org branch August 26, 2025 16:47
andrewshie-sentry pushed a commit that referenced this pull request Aug 26, 2025
… update a sentry app (#98080)

Add a method to `app_service` to fetch all active (not pending deletion)
sentry apps for an organization and a method to update a sentry app.
Used for getsentry/getsentry#18204
constantinius pushed a commit that referenced this pull request Aug 27, 2025
… update a sentry app (#98080)

Add a method to `app_service` to fetch all active (not pending deletion)
sentry apps for an organization and a method to update a sentry app.
Used for getsentry/getsentry#18204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants